falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "PRAGYA MITTAL" <mittal.pragy...@gmail.com>
Subject Re: Review Request 41748: [FALCON-1699] Test fixes for RetentionTest, LineageApiTest, TouchAPIPrismAndServerTest, FeedReplicationTest and few fortifications
Date Mon, 04 Jan 2016 14:46:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41748/#review112579
-----------------------------------------------------------



falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java
(line 530)
<https://reviews.apache.org/r/41748/#comment173074>

    Java doc missing.



falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java
(line 531)
<https://reviews.apache.org/r/41748/#comment173075>

    numberOfRetries can be a parameter of the function itself. User may want to change it
according to his/her test case. You can also set 5 as default value and let user override
it if he wants.



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java
(line 252)
<https://reviews.apache.org/r/41748/#comment173076>

    assertTrue(boolean condition, String message) can be used.



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TouchAPIPrismAndServerTest.java
(line 108)
<https://reviews.apache.org/r/41748/#comment173077>

    Why is this required?



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java
(line 190)
<https://reviews.apache.org/r/41748/#comment173078>

    TimeUtil.addMinsToTime() can be used instead of this.



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java
(line 83)
<https://reviews.apache.org/r/41748/#comment173079>

    Consider moving this test case out of the code instead of disabling it.


- PRAGYA MITTAL


On Dec. 28, 2015, 7 p.m., Paul Isaychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41748/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2015, 7 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1699
>     https://issues.apache.org/jira/browse/FALCON-1699
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Test fixes for RetentionTest, LineageApiTest, TouchAPIPrismAndServerTest, FeedReplicationTest
and few fortifications
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/Edge.java
c1a7eb8 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/KerberosHelper.java
c9f540f 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java
ae96044 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/BaseRequest.java
e5430eb 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java
6728edf 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TouchAPIPrismAndServerTest.java
1bffe9a 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatRetentionTest.java
d639c21 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java
8f45d1c 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java
73273f9 
> 
> Diff: https://reviews.apache.org/r/41748/diff/
> 
> 
> Testing
> -------
> 
> tested
> 
> 
> Thanks,
> 
> Paul Isaychuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message