falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 41747: [FALCON-1698] New tests for ProcessSetupTest, ClusterSetupTest, UI test fixes
Date Mon, 04 Jan 2016 14:37:36 GMT


> On Jan. 4, 2016, 10:48 a.m., Ajay Yadava wrote:
> > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/EntityPage.java,
line 409
> > <https://reviews.apache.org/r/41747/diff/1/?file=1176922#file1176922line409>
> >
> >     Why is the timeout OS specific?
> 
> Paul Isaychuk wrote:
>     We faced a need for this only on windows.

I always knew Linux is faster :P 

On a serious note, I feel this kind of issue may be machine dependent and might occur on other
low configuration hardware even in Linux(we have seen some falcon unit tests fail on mac laptops
while they run pretty smoothly on my high end ubuntu desktop), so it will be better to keep
a sleep irrespective of OS if it doesn't degrade the performance of tests singificantly.


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41747/#review112539
-----------------------------------------------------------


On Jan. 4, 2016, 12:53 p.m., Paul Isaychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41747/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 12:53 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1698
>     https://issues.apache.org/jira/browse/FALCON-1698
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Adding new tests to ProcessSetupTest, ClusterSetupTest; UI test fixes related to UI changes.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ClusterMerlin.java
fe1338a 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java
7607aa6 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java
67d9ee2 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java
bcada4a 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/EntityPage.java
f7499b7 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java
7f87091 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ProcessWizardPage.java
5dcd700 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java
5efa5b2 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSummaryTest.java
989e4b3 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ProcessSetupTest.java
eae5137 
> 
> Diff: https://reviews.apache.org/r/41747/diff/
> 
> 
> Testing
> -------
> 
> done
> 
> 
> Thanks,
> 
> Paul Isaychuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message