falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "PRAGYA MITTAL" <mittal.pragy...@gmail.com>
Subject Re: Review Request 41742: [FALCON-1697] Stabilization of scenarios which are based on instances lifecycle
Date Mon, 04 Jan 2016 12:40:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41742/#review112561
-----------------------------------------------------------



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java
(line 72)
<https://reviews.apache.org/r/41742/#comment173056>

    Why 2010. Consider giving a date of 2015.



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java
(line 90)
<https://reviews.apache.org/r/41742/#comment173059>

    One concern please, why did we change this test case. Existing combination is fulfilling
all the scenarios as far as possible.



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java
(line 238)
<https://reviews.apache.org/r/41742/#comment173057>

    Minor spelling mistake :
    check on order



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java
(line 255)
<https://reviews.apache.org/r/41742/#comment173058>

    Does it mean we intend to list feed instances using 'list' api in this test case ?


- PRAGYA MITTAL


On Dec. 28, 2015, 4:05 p.m., Paul Isaychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41742/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2015, 4:05 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1697
>     https://issues.apache.org/jira/browse/FALCON-1697
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Fixes related to stabilization of tests which are based on instance lifecycle by adding
timeouts, separating data required for different instances etc, optimization scenario.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java
3d05ae9 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java
6493133 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceSuspendTest.java
f673314 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java
7ad4c8e 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListProcessInstancesTest.java
43bdd87 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/EntityPageTest.java
4ad775e 
> 
> Diff: https://reviews.apache.org/r/41742/diff/
> 
> 
> Testing
> -------
> 
> Testing done.
> 
> 
> Thanks,
> 
> Paul Isaychuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message