falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 41742: [FALCON-1697] Stabilization of scenarios which are based on instances lifecycle
Date Mon, 04 Jan 2016 12:12:37 GMT


> On Jan. 4, 2016, 10:40 a.m., Ajay Yadava wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java,
line 343
> > <https://reviews.apache.org/r/41742/diff/2/?file=1176901#file1176901line343>
> >
> >     Is sleep required here, I mean we have already waited for instance to reach
suspended state, so why is another wait required?
> 
> Paul Isaychuk wrote:
>     While we are sure that instances were suspended, we need some more delay between
suspend and resume actions.
>     
>     We faced issue when instances were suspended (and waitTillInstanceReachState(...)
shows the same) but because resume is performed immidiately after suspend (waitTillInstanceReachState
gets suspended instances in first check iteration, so it doesn't take much time), not all
instances were resumed. After adding sleep, issue didn't reproduce.

Ok. Makes sense.


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41742/#review112203
-----------------------------------------------------------


On Dec. 28, 2015, 4:05 p.m., Paul Isaychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41742/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2015, 4:05 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1697
>     https://issues.apache.org/jira/browse/FALCON-1697
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Fixes related to stabilization of tests which are based on instance lifecycle by adding
timeouts, separating data required for different instances etc, optimization scenario.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java
3d05ae9 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java
6493133 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceSuspendTest.java
f673314 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java
7ad4c8e 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListProcessInstancesTest.java
43bdd87 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/EntityPageTest.java
4ad775e 
> 
> Diff: https://reviews.apache.org/r/41742/diff/
> 
> 
> Testing
> -------
> 
> Testing done.
> 
> 
> Thanks,
> 
> Paul Isaychuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message