Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 760FA18E2B for ; Wed, 23 Dec 2015 18:25:13 +0000 (UTC) Received: (qmail 94270 invoked by uid 500); 23 Dec 2015 18:25:13 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 94231 invoked by uid 500); 23 Dec 2015 18:25:13 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 94220 invoked by uid 99); 23 Dec 2015 18:25:13 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Dec 2015 18:25:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A704C180059 for ; Wed, 23 Dec 2015 18:25:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 6.14 X-Spam-Level: ****** X-Spam-Status: No, score=6.14 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FORGED_YAHOO_RCVD=1.022, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, REPTO_QUOTE_YAHOO=0.49, RP_MATCHES_RCVD=-0.554] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 2qMs_NlQwPwY for ; Wed, 23 Dec 2015 18:25:11 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 8DF582114D for ; Wed, 23 Dec 2015 18:25:10 +0000 (UTC) Received: (qmail 94196 invoked by uid 99); 23 Dec 2015 18:25:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Dec 2015 18:25:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 35F1F295FDA; Wed, 23 Dec 2015 18:25:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8785321672976236887==" MIME-Version: 1.0 Subject: Re: Review Request 40779: [Falcon-1377] Add tests in falcon for the Triage API From: "Karishma Gulati" To: "Karishma Gulati" , "Ajay Yadava" , "Falcon" , "PRAGYA MITTAL" Date: Wed, 23 Dec 2015 18:25:09 -0000 Message-ID: <20151223182509.664.18597@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Karishma Gulati" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40779/ X-Sender: "Karishma Gulati" References: <20151223104920.664.64674@reviews.apache.org> In-Reply-To: <20151223104920.664.64674@reviews.apache.org> Reply-To: "Karishma Gulati" X-ReviewRequest-Repository: falcon-git --===============8785321672976236887== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40779/ ----------------------------------------------------------- (Updated Dec. 23, 2015, 6:25 p.m.) Review request for Falcon. Changes ------- Addressed all review comments. Repository: falcon-git Description ------- Add tests for the feature explained in https://issues.apache.org/jira/browse/FALCON-796 - Enable users to triage data processing issues through falcon. As part of this patch, will add tests corresponding to single colo processing. Cross-colo instance triage tests wil be added in a separate class as part of a separate patch. Diffs (updated) ----- falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java 921a303 falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java d8df0fb falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/EntityLineageUtil.java 2df474d falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java PRE-CREATION Diff: https://reviews.apache.org/r/40779/diff/ Testing ------- Thanks, Karishma Gulati --===============8785321672976236887==--