Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@falcon.apache.org
Content-Type: multipart/alternative;
 boundary="===============7459750119160418273=="
MIME-Version: 1.0
Subject: Re: Review Request 41568: [FALCON-1567] Test case for Lifecycle
 feature .
From: "pavan kumar kolamuri" <pavan.kolamuri@gmail.com>
To: "Ajay Yadava" <ajaynsit@gmail.com>
Cc: "pavan kumar kolamuri" <pavan.kolamuri@gmail.com>,
 "Falcon" <dev@falcon.incubator.apache.org>,
 "PRAGYA MITTAL" <mittal.pragya23@gmail.com>
Date: Mon, 21 Dec 2015 06:57:27 -0000
Message-ID: <20151221065727.664.20697@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "pavan kumar kolamuri" <noreply@reviews.apache.org>
References: <20151218214428.11596.99935@reviews.apache.org>
In-Reply-To: <20151218214428.11596.99935@reviews.apache.org>
Reply-To: "pavan kumar kolamuri" <pavan.kolamuri@gmail.com>

--===============7459750119160418273==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41568/#review111443
-----------------------------------------------------------


falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java (line 834)
<https://reviews.apache.org/r/41568/#comment171643>

    Just adding along with sandeep comments make sure always atleast pass empty configuration object, since NP might occur when this method is called


falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java (line 304)
<https://reviews.apache.org/r/41568/#comment171639>

    Make it submit a feed having retention frequency less than 1 hour it will fail. Since in minutes also some one can give minutes(120)


falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java (line 361)
<https://reviews.apache.org/r/41568/#comment171640>

    Move this to method since all methods need this in case of lifecycle


falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java (line 391)
<https://reviews.apache.org/r/41568/#comment171642>

    If result is passed with Data provider then we can simply have one if and else . If for success and else for failure


falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java (line 415)
<https://reviews.apache.org/r/41568/#comment171641>

    Pass result along with data then in test method we can check against result.


- pavan kumar kolamuri


On Dec. 18, 2015, 9:44 p.m., PRAGYA MITTAL wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41568/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2015, 9:44 p.m.)
> 
> 
> Review request for Falcon and Ajay Yadava.
> 
> 
> Bugs: FALCON-1567
>     https://issues.apache.org/jira/browse/FALCON-1567
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Add test cases for https://issues.apache.org/jira/browse/FALCON-965
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java ae96044 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java 8f45d1c 
> 
> Diff: https://reviews.apache.org/r/41568/diff/
> 
> 
> Testing
> -------
> 
> Tested.
> 
> 
> Thanks,
> 
> PRAGYA MITTAL
> 
>


--===============7459750119160418273==--