Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@falcon.apache.org
Content-Type: multipart/alternative;
 boundary="===============8400964257243470412=="
MIME-Version: 1.0
Subject: Re: Review Request 40779: [Falcon-1377] Add tests in falcon for the
 Triage API
From: "Karishma Gulati" <gulati.karishma@yahoo.com>
To: "Karishma Gulati" <gulati.karishma@yahoo.com>,
 "Falcon" <dev@falcon.incubator.apache.org>,
 "PRAGYA MITTAL" <mittal.pragya23@gmail.com>
Date: Thu, 17 Dec 2015 14:50:52 -0000
Message-ID: <20151217145052.1673.98246@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Karishma Gulati" <noreply@reviews.apache.org>
References: <20151130144039.28068.39625@reviews.apache.org>
In-Reply-To: <20151130144039.28068.39625@reviews.apache.org>
Reply-To: "Karishma Gulati" <gulati.karishma@yahoo.com>

--===============8400964257243470412==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Nov. 30, 2015, 2:40 p.m., PRAGYA MITTAL wrote:
> > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java, line 51
> > <https://reviews.apache.org/r/40779/diff/1/?file=1148010#file1148010line51>
> >
> >     inputDataRoot and outputDataRoot ?

We need to delete all test data (created for input and output feeds) as well, which wasn't getting deleted earlier. All our feed templates have these directories as their default data path.


> On Nov. 30, 2015, 2:40 p.m., PRAGYA MITTAL wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java, line 536
> > <https://reviews.apache.org/r/40779/diff/1/?file=1148011#file1148011line536>
> >
> >     Add to AssertUtil.

It's a very test logic specific assertion.


- Karishma


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40779/#review108314
-----------------------------------------------------------


On Dec. 17, 2015, 2:50 p.m., Karishma Gulati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40779/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2015, 2:50 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Add tests for the feature explained in https://issues.apache.org/jira/browse/FALCON-796 - Enable users to triage data processing issues through falcon.
> As part of this patch, will add tests corresponding to single colo processing. Cross-colo instance triage tests wil be added in a separate class as part of a separate patch.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java 921a303 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 3d05ae9 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java 00ef79d 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40779/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Karishma Gulati
> 
>


--===============8400964257243470412==--