Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E5B5418760 for ; Wed, 16 Dec 2015 04:24:15 +0000 (UTC) Received: (qmail 1701 invoked by uid 500); 16 Dec 2015 04:24:15 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 1658 invoked by uid 500); 16 Dec 2015 04:24:15 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 1647 invoked by uid 99); 16 Dec 2015 04:24:15 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Dec 2015 04:24:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D027A1A0679 for ; Wed, 16 Dec 2015 04:24:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.878 X-Spam-Level: **** X-Spam-Status: No, score=4.878 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.554] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id vU4REoifYkw6 for ; Wed, 16 Dec 2015 04:24:13 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 4798C20EBA for ; Wed, 16 Dec 2015 04:24:11 +0000 (UTC) Received: (qmail 1643 invoked by uid 99); 16 Dec 2015 04:24:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Dec 2015 04:24:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BC7BD2AE72B; Wed, 16 Dec 2015 04:24:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0598749933461093289==" MIME-Version: 1.0 Subject: Re: Review Request 40817: FALCON-1609: Add entity commands to falcon spring-shell CLI From: "Ajay Yadava" To: "Falcon" , "Ajay Yadava" Date: Wed, 16 Dec 2015 04:24:09 -0000 Message-ID: <20151216042409.19750.4003@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Ajay Yadava" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40817/ X-Sender: "Ajay Yadava" References: <20151201082114.1718.2505@reviews.apache.org> In-Reply-To: <20151201082114.1718.2505@reviews.apache.org> Reply-To: "Ajay Yadava" X-ReviewRequest-Repository: falcon-git --===============0598749933461093289== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40817/#review110611 ----------------------------------------------------------- Although there is base test class and test for FalconConnectionCommands, I didn't find any tests for EntityCommands. I am assuming it will be available in the final patch. cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java (line 117) nit: spacing between functions. cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java (line 59) Why is this command required? cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java (line 49) Is this complete list of EntityCommands? I couldn't find commands like entity defintion, hence wondering. client/src/main/java/org/apache/falcon/cli/FalconCLI.java (line 64) Type of the entity. Valid entity types are: cluster, feed, process and datasource. client/src/main/java/org/apache/falcon/cli/FalconCLI.java (line 70) Should be "Name of the entity, recommended but not mandatory to be unique." client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java (line 48) nit: Update an entity client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java (line 53) nit: Submits "an" entity client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java (line 55) nit: Validates an entity. client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java (line 88) Where is this method used in the new framework? - Ajay Yadava On Dec. 1, 2015, 8:21 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40817/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2015, 8:21 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1609 > https://issues.apache.org/jira/browse/FALCON-1609 > > > Repository: falcon-git > > > Description > ------- > > putting for early review > > > Diffs > ----- > > cli/src/main/java/org/apache/falcon/cli/FalconCLIRuntimeException.java b7fa4cd524bfcd50ac260dadc2a1f94021b3df03 > cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java dbd28fb74e2aaeedc94ed4ee43e688ea9efb15b0 > cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java cabe5a8083daf90456636d3378e410e3d95a4ada > cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java 6e091efcbe26ff7df7a3fe52e33b20f781b8d785 > cli/src/test/java/org/apache/falcon/cli/commands/FalconCLITest.java PRE-CREATION > cli/src/test/java/org/apache/falcon/cli/commands/FalconConnectionCommandsTest.java PRE-CREATION > client/src/main/java/org/apache/falcon/cli/FalconCLI.java 24f230ae66ba710945be76d176fbdbdbbcb3721c > client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java cb39a2fe95beae32dee930afb9bb78d85ebb58ea > client/src/main/java/org/apache/falcon/client/FalconClient.java b4b176224554fb5a86ebca2bcced980dc84d2dd6 > > Diff: https://reviews.apache.org/r/40817/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > > --===============0598749933461093289==--