Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9414C1837A for ; Tue, 15 Dec 2015 09:21:14 +0000 (UTC) Received: (qmail 81430 invoked by uid 500); 15 Dec 2015 09:21:14 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 81377 invoked by uid 500); 15 Dec 2015 09:21:14 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 81366 invoked by uid 99); 15 Dec 2015 09:21:14 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Dec 2015 09:21:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9A613C3083 for ; Tue, 15 Dec 2015 09:21:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.971 X-Spam-Level: *** X-Spam-Status: No, score=3.971 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ynhccS8Ej4Vo for ; Tue, 15 Dec 2015 09:21:12 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id 3F069429C8 for ; Tue, 15 Dec 2015 09:21:11 +0000 (UTC) Received: (qmail 81361 invoked by uid 99); 15 Dec 2015 09:21:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Dec 2015 09:21:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A64D01C0099; Tue, 15 Dec 2015 09:21:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0428185887652976769==" MIME-Version: 1.0 Subject: Re: Review Request 41342: FALCON-1652 Documentation for enabling native scheduler in falcon From: "Pallavi Rao" To: "PRAGYA MITTAL" Cc: "Falcon" , "Pallavi Rao" Date: Tue, 15 Dec 2015 09:21:09 -0000 Message-ID: <20151215092109.31807.67724@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Pallavi Rao" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41342/ X-Sender: "Pallavi Rao" References: <20151215065353.19749.9233@reviews.apache.org> In-Reply-To: <20151215065353.19749.9233@reviews.apache.org> Reply-To: "Pallavi Rao" X-ReviewRequest-Repository: falcon-git --===============0428185887652976769== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Dec. 15, 2015, 6:53 a.m., PRAGYA MITTAL wrote: > > docs/src/site/twiki/FalconNativeScheduler.twiki, line 76 > > > > > > In distributed mode, how can multiple servers share same derby db ? Any configuration required for it. Not applicable for Derby DB.. clarified that. > On Dec. 15, 2015, 6:53 a.m., PRAGYA MITTAL wrote: > > docs/src/site/twiki/FalconNativeScheduler.twiki, line 81 > > > > > > How to run this command in distributed mode (we can mention via server it has to be run) Clarified that only Falcon server needs to maintain state and the script needs to be run for Falcon server installation alone. > On Dec. 15, 2015, 6:53 a.m., PRAGYA MITTAL wrote: > > docs/src/site/twiki/FalconNativeScheduler.twiki, line 102 > > > > > > Can we add any other db that we plan to support in future. Mentioned that we may extend support to other DBs. > On Dec. 15, 2015, 6:53 a.m., PRAGYA MITTAL wrote: > > docs/src/site/twiki/FalconNativeScheduler.twiki, line 110 > > > > > > Is falcon dependent on a specific version of mysql ? I can mention the version it has been tested against. It should work with any version above that too. > On Dec. 15, 2015, 6:53 a.m., PRAGYA MITTAL wrote: > > docs/src/site/twiki/FalconNativeScheduler.twiki, line 112 > > > > > > falcon.statestore.jdbc.driver in case of mysql ? jdbc.url is the only property that needs to be changed. Have called it out. > On Dec. 15, 2015, 6:53 a.m., PRAGYA MITTAL wrote: > > docs/src/site/twiki/FalconNativeScheduler.twiki, line 113 > > > > > > *.falcon.statestore.jdbc.username=sa > > *.falcon.statestore.jdbc.password= > > *.falcon.statestore.connection.data.source=org.apache.commons.dbcp.BasicDataSource > > > > Does these property remain same for both mysql and derby ? Yes. Have called it out. > On Dec. 15, 2015, 6:53 a.m., PRAGYA MITTAL wrote: > > docs/src/site/twiki/FalconNativeScheduler.twiki, line 114 > > > > > > Can multiple servers use same mysql db? Yes. Mentioned the same in the doc. > On Dec. 15, 2015, 6:53 a.m., PRAGYA MITTAL wrote: > > docs/src/site/twiki/FalconNativeScheduler.twiki, line 116 > > > > > > Does user need to create 'statestore' db prior to running the script. If so , can root user do it or it has to a specific user ? For MySQL yes.. For derby, not necessary. Updated the doc. > On Dec. 15, 2015, 6:53 a.m., PRAGYA MITTAL wrote: > > docs/src/site/twiki/FalconNativeScheduler.twiki, line 117 > > > > > > Is mysql-connector.jar bundled in falcon or user needs to copy it. If user has to copy then where should we copy ? Nope. Absence of documentation means the user does not need to do anything :-). > On Dec. 15, 2015, 6:53 a.m., PRAGYA MITTAL wrote: > > docs/src/site/twiki/FalconNativeScheduler.twiki, line 137 > > > > > > Does migration require engine change in startup.properties ? Apart from enabling native scheduler nothing else. Called it out explicitly. > On Dec. 15, 2015, 6:53 a.m., PRAGYA MITTAL wrote: > > docs/src/site/twiki/FalconNativeScheduler.twiki, line 48 > > > > > > Does it mean we dont need OozieWorkflowEngine in the long run. > > If user wants to schedule some job via oozie and then some via scheduler, will this work even without changing engine in startup.properties . > > > > Can we be more clear on property dependency on engine (if any) Have tried to word this a little more clearly. > On Dec. 15, 2015, 6:53 a.m., PRAGYA MITTAL wrote: > > docs/src/site/twiki/falconcli/Schedule.twiki, line 16 > > > > > > *.workflow.engine.impl=org.apache.falcon.workflow.engine.OozieWorkflowEngine and user gives this property, what is the expected behaviour. Is this property dependent of the engine defined in startup.properties. Details have been added to FalconNativeScheduler page. - Pallavi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41342/#review110433 ----------------------------------------------------------- On Dec. 15, 2015, 5:27 a.m., Pallavi Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41342/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 5:27 a.m.) > > > Review request for Falcon and PRAGYA MITTAL. > > > Bugs: FALCON-1652 > https://issues.apache.org/jira/browse/FALCON-1652 > > > Repository: falcon-git > > > Description > ------- > > Documentation for enabling native scheduler in falcon > > > Diffs > ----- > > docs/src/site/twiki/Configuration.twiki 74da49a > docs/src/site/twiki/FalconDocumentation.twiki f384a42 > docs/src/site/twiki/FalconNativeScheduler.twiki PRE-CREATION > docs/src/site/twiki/falconcli/Schedule.twiki 63aa9c1 > src/conf/startup.properties 1694930 > > Diff: https://reviews.apache.org/r/41342/diff/ > > > Testing > ------- > > Compiled and ensured the html shows up properly on the browser. > > > Thanks, > > Pallavi Rao > > --===============0428185887652976769==--