Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ECD5B18C6A for ; Tue, 15 Dec 2015 06:38:10 +0000 (UTC) Received: (qmail 78267 invoked by uid 500); 15 Dec 2015 06:38:05 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 78211 invoked by uid 500); 15 Dec 2015 06:38:05 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 78200 invoked by uid 99); 15 Dec 2015 06:38:05 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Dec 2015 06:38:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 3105B1A048E for ; Tue, 15 Dec 2015 06:38:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.628 X-Spam-Level: **** X-Spam-Status: No, score=4.628 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.554] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id l02iS6lzReOX for ; Tue, 15 Dec 2015 06:38:04 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id 459EB265D8 for ; Tue, 15 Dec 2015 06:38:04 +0000 (UTC) Received: (qmail 78136 invoked by uid 99); 15 Dec 2015 06:38:04 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Dec 2015 06:38:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 966BE294454; Tue, 15 Dec 2015 06:38:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8339100997523837678==" MIME-Version: 1.0 Subject: Re: Review Request 40698: FALCON-1512 Implement touch feature for native scheduler From: "pavan kumar kolamuri" To: "pavan kumar kolamuri" , "Falcon" , "Pallavi Rao" Date: Tue, 15 Dec 2015 06:38:03 -0000 Message-ID: <20151215063803.19749.66207@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "pavan kumar kolamuri" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40698/ X-Sender: "pavan kumar kolamuri" References: <20151215062135.19749.64300@reviews.apache.org> In-Reply-To: <20151215062135.19749.64300@reviews.apache.org> Reply-To: "pavan kumar kolamuri" X-ReviewRequest-Repository: falcon-git --===============8339100997523837678== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40698/#review110439 ----------------------------------------------------------- Ship it! Ship It! - pavan kumar kolamuri On Dec. 15, 2015, 6:21 a.m., Pallavi Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40698/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 6:21 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1512 > https://issues.apache.org/jira/browse/FALCON-1512 > > > Repository: falcon-git > > > Description > ------- > > Touch feature was not implemented for native scheduler. Adding it now. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/util/DateUtil.java b70fa20 > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 91230b2 > scheduler/src/main/java/org/apache/falcon/execution/NotificationHandler.java 2a2589e > scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java ebc05ec > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java ac7cde8 > scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 70c8353 > scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java 087114f > > Diff: https://reviews.apache.org/r/40698/diff/ > > > Testing > ------- > > Manual testing done. Couldn't add UTs are there are interactions with Oozie. > > > Thanks, > > Pallavi Rao > > --===============8339100997523837678==--