Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1583318864 for ; Mon, 14 Dec 2015 16:51:04 +0000 (UTC) Received: (qmail 54485 invoked by uid 500); 14 Dec 2015 16:51:04 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 54444 invoked by uid 500); 14 Dec 2015 16:51:04 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 54429 invoked by uid 99); 14 Dec 2015 16:51:03 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Dec 2015 16:51:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 3BF661A02FC for ; Mon, 14 Dec 2015 16:51:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.427 X-Spam-Level: *** X-Spam-Status: No, score=3.427 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.554] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id vLJq7HqdOXB1 for ; Mon, 14 Dec 2015 16:51:02 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id F100520EBA for ; Mon, 14 Dec 2015 16:51:00 +0000 (UTC) Received: (qmail 54418 invoked by uid 99); 14 Dec 2015 16:51:00 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Dec 2015 16:51:00 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9A449293FBB; Mon, 14 Dec 2015 16:50:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8223514063079932591==" MIME-Version: 1.0 Subject: Re: Review Request 41339: FALCON-1617: Enable SLA monitoring for instances in past From: "Narayan Periwal" To: "sandeep samudrala" , "Falcon" , "Narayan Periwal" Date: Mon, 14 Dec 2015 16:50:59 -0000 Message-ID: <20151214165059.19749.64801@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Narayan Periwal" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41339/ X-Sender: "Narayan Periwal" References: <20151214163428.19750.43693@reviews.apache.org> In-Reply-To: <20151214163428.19750.43693@reviews.apache.org> Reply-To: "Narayan Periwal" X-ReviewRequest-Repository: falcon-git --===============8223514063079932591== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Dec. 14, 2015, 4:34 p.m., sandeep samudrala wrote: > > common/src/main/java/org/apache/falcon/entity/FeedHelper.java, line 1021 > > > > > > There is a small issue with getRetention().getLimit() w.r.t default frequency. > > Can you change this method to call > > > > getRetentionFrequency(Feed feed, String clusterName) > > > > from this api? @Sandeep, what is the issue? - Narayan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41339/#review110250 ----------------------------------------------------------- On Dec. 14, 2015, 10:17 a.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41339/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2015, 10:17 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1617 > https://issues.apache.org/jira/browse/FALCON-1617 > > > Repository: falcon-git > > > Description > ------- > > Currently on enabling SLA monitoring it doesn't consider instances which had nominal time in past for SLA monitoring. With this JIRA we would like to enable this. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/FeedHelper.java 29daff3 > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java b302539 > > Diff: https://reviews.apache.org/r/41339/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > Narayan Periwal > > --===============8223514063079932591==--