Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9EBEA18F48 for ; Mon, 14 Dec 2015 06:25:56 +0000 (UTC) Received: (qmail 3932 invoked by uid 500); 14 Dec 2015 06:25:56 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 3884 invoked by uid 500); 14 Dec 2015 06:25:56 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 3868 invoked by uid 99); 14 Dec 2015 06:25:56 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Dec 2015 06:25:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id CE6E41A025B for ; Mon, 14 Dec 2015 06:25:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.427 X-Spam-Level: *** X-Spam-Status: No, score=3.427 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.554] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 8b1XyQYiohXx for ; Mon, 14 Dec 2015 06:25:51 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id DAB2C26ACA for ; Mon, 14 Dec 2015 06:25:50 +0000 (UTC) Received: (qmail 3727 invoked by uid 99); 14 Dec 2015 06:25:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Dec 2015 06:25:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E7A02293D65; Mon, 14 Dec 2015 06:25:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3406649025722373477==" MIME-Version: 1.0 Subject: Re: Review Request 40636: FALCON-1577: Migration of EntityManagerJerseyIT to use falcon unit From: "Narayan Periwal" To: "pavan kumar kolamuri" , "Falcon" , "Narayan Periwal" Date: Mon, 14 Dec 2015 06:25:49 -0000 Message-ID: <20151214062549.19750.69709@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Narayan Periwal" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40636/ X-Sender: "Narayan Periwal" References: <20151207071300.31128.91212@reviews.apache.org> In-Reply-To: <20151207071300.31128.91212@reviews.apache.org> Reply-To: "Narayan Periwal" X-ReviewRequest-Repository: falcon-git --===============3406649025722373477== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Dec. 7, 2015, 7:13 a.m., pavan kumar kolamuri wrote: > > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java, line 165 > > > > > > This method is only scheduling process but method name seems it will schedule all Agreed. > On Dec. 7, 2015, 7:13 a.m., pavan kumar kolamuri wrote: > > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java, line 172 > > > > > > Pls change this method name also as it is not only scheduling process Agreed. - Narayan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40636/#review109125 ----------------------------------------------------------- On Nov. 26, 2015, 12:47 p.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40636/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2015, 12:47 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1577 > https://issues.apache.org/jira/browse/FALCON-1577 > > > Repository: falcon-git > > > Description > ------- > > In this jira, we migrate EntityManagerJerseyIT using falcon unit. > > > Diffs > ----- > > unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 9eb4277 > unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 2a73516 > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 23c59f4 > webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 6458b59 > webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java 1d49353 > webapp/src/test/java/org/apache/falcon/util/OozieTestUtils.java 804b2ed > > Diff: https://reviews.apache.org/r/40636/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > Narayan Periwal > > --===============3406649025722373477==--