Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4A2F118367 for ; Fri, 11 Dec 2015 14:20:13 +0000 (UTC) Received: (qmail 78467 invoked by uid 500); 11 Dec 2015 14:20:13 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 78426 invoked by uid 500); 11 Dec 2015 14:20:13 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 78397 invoked by uid 99); 11 Dec 2015 14:20:12 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Dec 2015 14:20:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 70140180A38 for ; Fri, 11 Dec 2015 14:20:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.628 X-Spam-Level: *** X-Spam-Status: No, score=3.628 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.554] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id hSDeWLsilLOO for ; Fri, 11 Dec 2015 14:20:07 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id 8141A265DB for ; Fri, 11 Dec 2015 14:20:07 +0000 (UTC) Received: (qmail 78122 invoked by uid 99); 11 Dec 2015 14:20:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Dec 2015 14:20:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 91C821D9C37; Fri, 11 Dec 2015 14:20:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3658517594712383292==" MIME-Version: 1.0 Subject: Re: Review Request 40769: Integration tests for Falcon Native Scheduler From: "pavan kumar kolamuri" To: "pavan kumar kolamuri" , "Falcon" Date: Fri, 11 Dec 2015 14:20:06 -0000 Message-ID: <20151211142006.1618.56334@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "pavan kumar kolamuri" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40769/ X-Sender: "pavan kumar kolamuri" References: <20151127140023.17333.86234@reviews.apache.org> In-Reply-To: <20151127140023.17333.86234@reviews.apache.org> Reply-To: "pavan kumar kolamuri" X-ReviewRequest-Repository: falcon-git --===============3658517594712383292== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40769/#review109963 ----------------------------------------------------------- scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java (line 162) Ok sure will do it. webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java (line 30) Ok will add - pavan kumar kolamuri On Nov. 27, 2015, 2 p.m., pavan kumar kolamuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40769/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2015, 2 p.m.) > > > Review request for Falcon. > > > Bugs: https://issues.apache.org/jira/browse/FALCON-1447 > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FALCON-1447 > > > Repository: falcon-git > > > Description > ------- > > For Native Scheduler we have tests where all services are mocked and even jobs are not scheduled in oozie. Integration tests are needed for Native Scheduler to run from end to end. > > > Diffs > ----- > > oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java f6e87c4 > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 16ef83a > scheduler/pom.xml 336997d > scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java ca2010b > scheduler/src/test/java/org/apache/falcon/state/AbstractSchedulerTestBase.java 48c1426 > unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 9eb4277 > unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java 0065c71 > unit/src/main/resources/oozie-site.xml 23d41eb > unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 2a73516 > unit/src/test/java/org/apache/falcon/unit/examples/JavaHelloWorldExample.java PRE-CREATION > webapp/pom.xml 428f67e > webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java PRE-CREATION > webapp/src/test/java/org/apache/falcon/resource/EntitySchedulerManagerJerseyIT.java PRE-CREATION > webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java PRE-CREATION > webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 6458b59 > webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java 1d49353 > webapp/src/test/resources/helloworldworkflow.xml PRE-CREATION > webapp/src/test/resources/local-process-noinputs-template.xml PRE-CREATION > webapp/src/test/resources/runtime.properties 1da0ca7 > webapp/src/test/resources/startup.properties 756f315 > > Diff: https://reviews.apache.org/r/40769/diff/ > > > Testing > ------- > > These are test cases itself > > > Thanks, > > pavan kumar kolamuri > > --===============3658517594712383292==--