Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C823218752 for ; Fri, 11 Dec 2015 09:24:37 +0000 (UTC) Received: (qmail 3660 invoked by uid 500); 11 Dec 2015 09:24:37 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 3611 invoked by uid 500); 11 Dec 2015 09:24:37 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 3600 invoked by uid 99); 11 Dec 2015 09:24:37 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Dec 2015 09:24:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id E838D1A2441 for ; Fri, 11 Dec 2015 09:24:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.427 X-Spam-Level: *** X-Spam-Status: No, score=3.427 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.554] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 0YxSXFD3vzNF for ; Fri, 11 Dec 2015 09:24:35 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 852BA21271 for ; Fri, 11 Dec 2015 09:24:34 +0000 (UTC) Received: (qmail 3595 invoked by uid 99); 11 Dec 2015 09:24:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Dec 2015 09:24:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 38AB11D9C37; Fri, 11 Dec 2015 09:24:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7618110890708751328==" MIME-Version: 1.0 Subject: Re: Review Request 41203: FALCON-1572 Only one instance is running in a process when run using Native Scheduler From: "Pallavi Rao" To: "pavan kumar kolamuri" , "Falcon" , "Pallavi Rao" Date: Fri, 11 Dec 2015 09:24:33 -0000 Message-ID: <20151211092433.1619.72275@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Pallavi Rao" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41203/ X-Sender: "Pallavi Rao" References: <20151210125141.1619.22450@reviews.apache.org> In-Reply-To: <20151210125141.1619.22450@reviews.apache.org> Reply-To: "Pallavi Rao" X-ReviewRequest-Repository: falcon-git --===============7618110890708751328== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41203/ ----------------------------------------------------------- (Updated Dec. 11, 2015, 9:24 a.m.) Review request for Falcon. Changes ------- Added changes to ensure order of notification too. Bugs: FALCON-1572 https://issues.apache.org/jira/browse/FALCON-1572 Repository: falcon-git Description ------- Wrong Datastructure was used to load and store into cache. Diffs (updated) ----- scheduler/pom.xml 336997d scheduler/src/main/java/org/apache/falcon/execution/EntityExecutor.java 88d88c1 scheduler/src/main/java/org/apache/falcon/execution/ExecutionInstance.java 5f96d3f scheduler/src/main/java/org/apache/falcon/execution/FalconExecutionService.java b6741a4 scheduler/src/main/java/org/apache/falcon/execution/NotificationHandler.java b071f5f scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java 23f2b4e scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java ace8444 scheduler/src/test/java/org/apache/falcon/notification/service/SchedulerServiceTest.java c43ccf0 Diff: https://reviews.apache.org/r/41203/diff/ Testing ------- Manual testing done. Once ITs are checked in, will add a test case for this too. Thanks, Pallavi Rao --===============7618110890708751328==--