Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 35B9718EBC for ; Thu, 10 Dec 2015 11:26:17 +0000 (UTC) Received: (qmail 27694 invoked by uid 500); 10 Dec 2015 11:26:14 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 27648 invoked by uid 500); 10 Dec 2015 11:26:14 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 27637 invoked by uid 99); 10 Dec 2015 11:26:13 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Dec 2015 11:26:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 612AE180AD9 for ; Thu, 10 Dec 2015 11:26:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.628 X-Spam-Level: **** X-Spam-Status: No, score=4.628 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.554] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id kzF6ISK5O595 for ; Thu, 10 Dec 2015 11:26:08 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 6F66E2026F for ; Thu, 10 Dec 2015 11:26:07 +0000 (UTC) Received: (qmail 27288 invoked by uid 99); 10 Dec 2015 11:26:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Dec 2015 11:26:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 98780292D4A; Thu, 10 Dec 2015 11:26:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5871538823609644420==" MIME-Version: 1.0 Subject: Re: Review Request 41198: FALCON-1656 Improve FeedHelper:getRetentionFrequency method From: "sandeep samudrala" To: "Ajay Yadava" , "Falcon" , "sandeep samudrala" Date: Thu, 10 Dec 2015 11:26:05 -0000 Message-ID: <20151210112605.1618.93331@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "sandeep samudrala" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41198/ X-Sender: "sandeep samudrala" References: <20151210111903.1618.69549@reviews.apache.org> In-Reply-To: <20151210111903.1618.69549@reviews.apache.org> Reply-To: "sandeep samudrala" X-ReviewRequest-Repository: falcon-git --===============5871538823609644420== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41198/#review109739 ----------------------------------------------------------- Ship it! Ship It! - sandeep samudrala On Dec. 10, 2015, 11:19 a.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41198/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2015, 11:19 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1656 > https://issues.apache.org/jira/browse/FALCON-1656 > > > Repository: falcon-git > > > Description > ------- > > Improve FeedHelper:getRetentionFrequency method > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/FeedHelper.java d601c5d > common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java c70f18d > common/src/main/java/org/apache/falcon/lifecycle/retention/AgeBasedDelete.java ccb0290 > common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 3e422fc > lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedCoordinatorBuilder.java e3e7fec > > Diff: https://reviews.apache.org/r/41198/diff/ > > > Testing > ------- > > Unit tests already exist, just a refactoring. > > > Thanks, > > Ajay Yadava > > --===============5871538823609644420==--