Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@falcon.apache.org
Content-Type: multipart/alternative;
 boundary="===============1947299679390548997=="
MIME-Version: 1.0
Subject: Re: Review Request 40892: FALCON-1644 Retention : Some feed instances
 are never deleted by retention jobs.
From: "Balu Vellanki" <bvellanki@hortonworks.com>
To: "Venkat Ranganathan" <n.r.v@live.com>
Cc: "Ying Zheng" <yzheng@hortonworks.com>,
 "Balu Vellanki" <bvellanki@hortonworks.com>,
 "sandeep samudrala" <sandysmdl@gmail.com>,
 "Falcon" <dev@falcon.incubator.apache.org>,
 "Ajay Yadava" <ajaynsit@gmail.com>
Date: Tue, 08 Dec 2015 19:20:17 -0000
Message-ID: <20151208192017.1618.25928@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Balu Vellanki" <noreply@reviews.apache.org>
References: <20151203043919.1719.64678@reviews.apache.org>
In-Reply-To: <20151203043919.1719.64678@reviews.apache.org>
Reply-To: "Balu Vellanki" <bvellanki@hortonworks.com>

--===============1947299679390548997==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40892/
-----------------------------------------------------------

(Updated Dec. 8, 2015, 7:20 p.m.)


Review request for Falcon and Venkat Ranganathan.


Changes
-------

Attaching a new patch that incorporates feedback provided by Falcon team. This patch has
- Incorporated feedback made in review board.
- Introduced a new runtime property "falcon.retention.keep.instances.beyond.validity", set to true by default. This retains existing behavior. Users can set this property to false, and ensure deletion of all instances.
- Updated retention documentation.


Bugs: Falcon-1644
    https://issues.apache.org/jira/browse/Falcon-1644


Repository: falcon-git


Description
-------

Here is a sample feed validity.

        <cluster name="primaryCluster" type="source">
            <validity start="2015-10-30T01:00Z" end="2015-10-30T10:00Z"/>
            <retention limit="hours(10)" action="delete"/>
        </cluster>

In the above example, the validity time is "the time interval when the feed is valid on this cluster". After the validity time ends, falcon is not expected to perform any operations on the feed. The retention job for this feed will be run from validity start time up to validity end time, and will delete any feed instances older than 10 hours. Some instances of Feed will never be deleted. In the above example, feed instances at between 2015-10-30T00:00Z and 2015-10-30T10:00Z will never be deleted.
Ideally, the retention coordinator job should run from "validity start time" up to "validity end time + retention age limit" to ensure all instances are handled.


Diffs (updated)
-----

  common/src/main/java/org/apache/falcon/entity/FeedHelper.java d601c5d 
  common/src/main/resources/runtime.properties f499dd9 
  docs/src/site/twiki/FalconDocumentation.twiki f384a42 
  oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionCoordinatorBuilder.java 69ca2c3 
  oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java d034b1a 
  src/conf/runtime.properties 4bc1bc0 
  webapp/src/test/resources/runtime.properties 1da0ca7 

Diff: https://reviews.apache.org/r/40892/diff/


Testing
-------

End2End testing done to ensure retention coord endtime is set to "validity end time + retention age limit"


Thanks,

Balu Vellanki


--===============1947299679390548997==--