falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peeyush Bishnoi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-1656) Improve FeedHelper:getRetentionFrequency method
Date Thu, 10 Dec 2015 09:02:10 GMT

    [ https://issues.apache.org/jira/browse/FALCON-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050381#comment-15050381
] 

Peeyush Bishnoi commented on FALCON-1656:
-----------------------------------------

Patch looks good. 
Initially variable retentionFrequency is getting set to "null" and also it is getting returned
from the function getRetentionFrequency. Is null check not required to avoid NPE, wherever
this variable is getting used.

> Improve FeedHelper:getRetentionFrequency method
> -----------------------------------------------
>
>                 Key: FALCON-1656
>                 URL: https://issues.apache.org/jira/browse/FALCON-1656
>             Project: Falcon
>          Issue Type: Improvement
>            Reporter: Ajay Yadava
>            Assignee: Ajay Yadava
>         Attachments: FALCON-1656.patch
>
>
> There are some edge cases that need to be handled so that it can be used by code outside
lifecycle builders.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message