falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pallavi Rao" <pallavi....@inmobi.com>
Subject Re: Review Request 38882: FALCON-1495: In instance status list, show all runs for instances when requested by user
Date Thu, 31 Dec 2015 10:26:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38882/#review112383
-----------------------------------------------------------



oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java (line 672)
<https://reviews.apache.org/r/38882/#comment172874>

    Instead of creating another method with duplicated code, can you think of may be using
the instance populated by performAction to perform further action?



oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java (line 679)
<https://reviews.apache.org/r/38882/#comment172875>

    The ERROR  is set for the first instance in the list, although something down the line
could have failed.


- Pallavi Rao


On Dec. 31, 2015, 5:23 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38882/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2015, 5:23 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1495
>     https://issues.apache.org/jira/browse/FALCON-1495
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Most of the times , when there are failures in the pipelines, retries run and the workflows
might have got succeeded in sub sequential retry. But for end user to figure out why it has
failed initially might be useful to understand for failures handling and SLA misses.
> 
> As of now to figure out the same, its a tedious task to get such information by either
going through oozie DB/logs or via the logs backed up in hdfs by the falcon postprocessing(which
is 100% reliable as in few cases, falcon post processing might fail or for some reason if
it couldn't back up the logs).
> 
> In either case, Falcon should abstract the oozie client layer to be used by end user,
and support all runs status to end user.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconInstanceCLI.java bfb1d65 
>   client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java e59af24 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 4a773c6 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java
b53efe6 
>   docs/src/site/twiki/FalconCLI.twiki 26e6b33 
>   docs/src/site/twiki/restapi/InstanceList.twiki 229d6f9 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java b486357

>   prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java d50d111

>   prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java
88131f3 
>   prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 801bd10

>   scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
bceab72 
>   unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 13375ef 
>   unit/src/main/java/org/apache/falcon/unit/LocalInstanceManager.java 148cbf7 
>   unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 382e0c9 
>   webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java 76c66f3 
>   webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java
1523b76 
>   webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 755efa3

> 
> Diff: https://reviews.apache.org/r/38882/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message