falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 41587: Listing API non-intuitive response if time > endTime
Date Tue, 29 Dec 2015 05:26:26 GMT


> On Dec. 21, 2015, 5:06 a.m., Pallavi Rao wrote:
> > client/src/main/java/org/apache/falcon/client/FalconClient.java, line 949
> > <https://reviews.apache.org/r/41587/diff/1/?file=1172720#file1172720line949>
> >
> >     Let us not introduce a new method. I believe you introduced this in order to
supply FeedInstanceResult to appropriate methods.
> >     
> >     It would be better to refactor the code to supply the appropriate class in order
methods too.

I had an offline discussion with Praveen Adlakha. The reason he took this approach is because
that one method is used in several apis. He wants to tackle all other APIs in a separate JIRA
as they will potentially entail changes on both client side and server side.


> On Dec. 21, 2015, 5:06 a.m., Pallavi Rao wrote:
> > client/src/main/java/org/apache/falcon/client/FalconCLIException.java, line 80
> > <https://reviews.apache.org/r/41587/diff/1/?file=1172719#file1172719line80>
> >
> >     Can't we replace the existing methods with these, rather than adding new ones?

Yes, we should have only one method. I had an offline discussion with Praveen Adlakha. The
reason he took this approach is because that one method is used in several apis. He wants
to tackle all other APIs in a separate JIRA as they will potentially entail changes on both
client side and server side.


> On Dec. 21, 2015, 5:06 a.m., Pallavi Rao wrote:
> > prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java, line
531
> > <https://reviews.apache.org/r/41587/diff/1/?file=1172722#file1172722line531>
> >
> >     Why not modify the newInstanceException method rather than use a generic newAPIException
method?

I had an offline discussion with @Praveen Adlakha on the same. I think the approach warrants
a few clarifications. He is doing it this way to make the change unobtrusive and at the same
time make it for 0.9 release without messing around with too many API calls. Changing existing
methods was causing cascading changes in several other API calls. He wants to handle them
in a separate JIRA.


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41587/#review111437
-----------------------------------------------------------


On Dec. 28, 2015, 2:07 p.m., Praveen Adlakha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41587/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2015, 2:07 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: falcon-1565
>     https://issues.apache.org/jira/browse/falcon-1565
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Listing API non-intuitive response if time > endTime
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconInstanceCLI.java 6ea34da 
>   client/src/main/java/org/apache/falcon/client/FalconCLIException.java 51ef952 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java aea39a6 
>   prism/src/main/java/org/apache/falcon/FalconWebException.java 666e3d7 
>   prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java da2fea7

>   prism/src/main/java/org/apache/falcon/resource/channel/HTTPChannel.java 6801398 
>   prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 96c99f0

> 
> Diff: https://reviews.apache.org/r/41587/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Praveen Adlakha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message