falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pallavi Rao" <pallavi....@inmobi.com>
Subject Re: Review Request 41545: Cascading delete in case of Native Scheduler
Date Thu, 24 Dec 2015 10:49:45 GMT


> On Dec. 23, 2015, 9:33 a.m., Pallavi Rao wrote:
> > scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java,
line 425
> > <https://reviews.apache.org/r/41545/diff/1/?file=1170861#file1170861line425>
> >
> >     Shouldn't delete entities and not instances?
> 
> pavan kumar kolamuri wrote:
>     Once instances are deleted entities will be deleted with Cascading delete, Thats
why removed this.

The constraint should be other way around. When an entity is deleted, all its instances must
get deleted.


- Pallavi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41545/#review111756
-----------------------------------------------------------


On Dec. 18, 2015, 1 p.m., pavan kumar kolamuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41545/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2015, 1 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1640
>     https://issues.apache.org/jira/browse/FALCON-1640
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Whenever entity is deleted corresponding instances should be deleted in statestore.
> 
> 
> Diffs
> -----
> 
>   common/src/test/java/org/apache/falcon/entity/AbstractTestBase.java a6d607b 
>   scheduler/src/main/java/org/apache/falcon/state/store/jdbc/EntityBean.java 03ada39

>   scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 0e3dfa9

>   scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java b2f8e80

>   scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java
6d5bd49 
> 
> Diff: https://reviews.apache.org/r/41545/diff/
> 
> 
> Testing
> -------
> 
> Unit testing with Derby and Manual testing with my-sql done.
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message