falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peeyush Bishnoi" <bpeey...@yahoo.co.in>
Subject Re: Review Request 41505: FALCON-1661 : Similar timestamp is getting added for Falcon instance vertex in GraphDB
Date Thu, 24 Dec 2015 08:02:33 GMT


> On Dec. 23, 2015, 10:30 a.m., Ajay Yadava wrote:
> > I had an offline discussion with Peeyush Bishnoi over this. Here is the summary
of the discussion.
> > 
> > 1. We can use vertex id as the unique parameter
> > 2. Although there is no direct API leveraging timestamp, there is a REXSTER api
exposed using which anyone can query any property, so all properties are in a way public contract.
> > 3. Using same property for nominal time can lead to issues if users don't migrate
incorrect data. e.g. if users query over a time range which has both incorrect data and correct
data, users will get several incorrect results. Using a second property will return no such
wrong results.
> > 4. If we decide to use the same property then it's fine but it will be helpful to
call out the change explicitly so that users are aware. 
> > 
> > Peeyush wants to try some more approaches, will get back on this after that.
> 
> Peeyush Bishnoi wrote:
>     Approach used in the attached patch to use nominal time for two purpose. First it
provide unique timestamp for each entity instance so that sorting the vertices done easily
(as it required for issue FALCON-1643). Second, instance vertices for an entity is getting
created with similar actual time (despite some vertices get create later) so it looks a bug
and also I have seen that nominal time is getting used other places instead of actual time.
> 
> Peeyush Bishnoi wrote:
>     Also I tried to use the timestamp in FALCON-1643, as timestamp option is not available
for user to query from Falcon metadata CLI and it will just be used internally. I will try
to use vertex id now as discussed.
> 
> Venkat Ranganathan wrote:
>     I prefer the use of id to sort instead of changing the semantics of what the timestamp
value is

Used vertex id instead of timestamp and FALCON-1643 is unblocked from this issue. I will fix
the timestamp issue when vertex is getting added in graphdb.


- Peeyush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41505/#review111769
-----------------------------------------------------------


On Dec. 18, 2015, 6:48 a.m., Peeyush Bishnoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41505/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2015, 6:48 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1661
>     https://issues.apache.org/jira/browse/FALCON-1661
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Similar timestamp is getting added for Falcon instance vertex in GraphDB
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java
b709857 
>   common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java f206ff1

>   common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 29f933d

> 
> Diff: https://reviews.apache.org/r/41505/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message