falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karishma Gulati" <gulati.karis...@yahoo.com>
Subject Re: Review Request 40779: [Falcon-1377] Add tests in falcon for the Triage API
Date Wed, 23 Dec 2015 10:46:08 GMT


> On Dec. 18, 2015, 1:12 p.m., PRAGYA MITTAL wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java,
line 150
> > <https://reviews.apache.org/r/40779/diff/2/?file=1168681#file1168681line150>
> >
> >     Add prism/server in dataprovider and merge prism/server methods.

The prism/server tests belong to different groups - embedded and distributed. So can't be
merged.


> On Dec. 18, 2015, 1:12 p.m., PRAGYA MITTAL wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java,
line 452
> > <https://reviews.apache.org/r/40779/diff/2/?file=1168681#file1168681line452>
> >
> >     Add one more arguement to define whether its server/prism. That way you can
merge test cases.

Can't, as explained above.


> On Dec. 18, 2015, 1:12 p.m., PRAGYA MITTAL wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java,
line 208
> > <https://reviews.apache.org/r/40779/diff/2/?file=1168681#file1168681line208>
> >
> >     Add the submitSchedule part to beforeMethod.

Some tests are modifying definitions befoe submitting and scheduling.


> On Dec. 18, 2015, 1:12 p.m., PRAGYA MITTAL wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java,
line 112
> > <https://reviews.apache.org/r/40779/diff/2/?file=1168681#file1168681line112>
> >
> >     There are already functions available to get entity name based on its type.
Consider using them.

Using your second suggestion instead


- Karishma


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40779/#review111173
-----------------------------------------------------------


On Dec. 17, 2015, 2:50 p.m., Karishma Gulati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40779/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2015, 2:50 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Add tests for the feature explained in https://issues.apache.org/jira/browse/FALCON-796
- Enable users to triage data processing issues through falcon.
> As part of this patch, will add tests corresponding to single colo processing. Cross-colo
instance triage tests wil be added in a separate class as part of a separate patch.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java
921a303 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java
3d05ae9 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java
00ef79d 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40779/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Karishma Gulati
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message