falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pallavi Rao" <pallavi....@inmobi.com>
Subject Re: Review Request 41545: Cascading delete in case of Native Scheduler
Date Wed, 23 Dec 2015 09:33:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41545/#review111756
-----------------------------------------------------------

Ship it!


Once you address the minor comment, the patch is good to go.


scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java (line
424)
<https://reviews.apache.org/r/41545/#comment172020>

    Shouldn't delete entities and not instances?


- Pallavi Rao


On Dec. 18, 2015, 1 p.m., pavan kumar kolamuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41545/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2015, 1 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1640
>     https://issues.apache.org/jira/browse/FALCON-1640
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Whenever entity is deleted corresponding instances should be deleted in statestore.
> 
> 
> Diffs
> -----
> 
>   common/src/test/java/org/apache/falcon/entity/AbstractTestBase.java a6d607b 
>   scheduler/src/main/java/org/apache/falcon/state/store/jdbc/EntityBean.java 03ada39

>   scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 0e3dfa9

>   scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java b2f8e80

>   scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java
6d5bd49 
> 
> Diff: https://reviews.apache.org/r/41545/diff/
> 
> 
> Testing
> -------
> 
> Unit testing with Derby and Manual testing with my-sql done.
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message