falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 41605: Make statestore credentials more secure and separate out statestore properties
Date Wed, 23 Dec 2015 09:29:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41605/#review111746
-----------------------------------------------------------



common/src/main/java/org/apache/falcon/util/StateStoreProperties.java (line 44)
<https://reviews.apache.org/r/41605/#comment171984>

    nit: I think "default.statestore.credentials.file" will be more apt as per it's purpose.



common/src/main/java/org/apache/falcon/util/StateStoreProperties.java (line 45)
<https://reviews.apache.org/r/41605/#comment171990>

    I am just wondering if there is any reasonable default for credentials that we store them.
May be we should just make the credentials file mandatory.



common/src/main/java/org/apache/falcon/util/StateStoreProperties.java (line 109)
<https://reviews.apache.org/r/41605/#comment171991>

    nit: can get rid of "+"



docs/src/site/twiki/FalconNativeScheduler.twiki (line 68)
<https://reviews.apache.org/r/41605/#comment171994>

    What happens if the permission is not 400?



docs/src/site/twiki/FalconNativeScheduler.twiki (line 72)
<https://reviews.apache.org/r/41605/#comment172021>

    Since there are two ways to configure credentials - file and values in properties file.
Is there a reason when someone will not want the secure option considering it doesn't impact
anything else.



scheduler/src/main/java/org/apache/falcon/state/store/AbstractStateStore.java (line 83)
<https://reviews.apache.org/r/41605/#comment172023>

    I know this is not part of this JIRA but still wondering, automatically defaulting to
InMemoryStateStore can cause memory issues in production scenarios. Does it make sense to
remove default value here or making default to MySQL?
    
    My hypothesis behind this suggestion is that InMemoryStateStore is useful only in development/testing
scenarios but in production scenarios this may cause issues.


- Ajay Yadava


On Dec. 21, 2015, 12:58 p.m., pavan kumar kolamuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41605/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2015, 12:58 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1601
>     https://issues.apache.org/jira/browse/FALCON-1601
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> We are bringing Falcon state Store DB for Native Scheduler as part of https://issues.apache.org/jira/browse/FALCON-1234,
We need to add more secureness by removing password properties from startup props and also
made this Statestore supports Mysql as well.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/util/ApplicationProperties.java 1d8cf49 
>   common/src/main/java/org/apache/falcon/util/StateStoreProperties.java PRE-CREATION

>   common/src/main/resources/statestore.properties PRE-CREATION 
>   docs/src/site/twiki/FalconNativeScheduler.twiki 9403ae7 
>   scheduler/src/main/java/org/apache/falcon/state/store/AbstractStateStore.java 2d576e5

>   scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java 151c2c2

>   scheduler/src/main/java/org/apache/falcon/state/store/service/FalconJPAService.java
72d1aba 
>   scheduler/src/main/java/org/apache/falcon/tools/FalconStateStoreDBCLI.java f4058c8

>   scheduler/src/test/java/org/apache/falcon/notification/service/SchedulerServiceTest.java
5a66518 
>   scheduler/src/test/java/org/apache/falcon/state/AbstractSchedulerTestBase.java a8be06d

>   scheduler/src/test/java/org/apache/falcon/state/EntityStateServiceTest.java 6676754

>   scheduler/src/test/java/org/apache/falcon/state/InstanceStateServiceTest.java f0ae7b2

>   scheduler/src/test/java/org/apache/falcon/workflow/engine/WorkflowEngineFactoryTest.java
7e502cd 
>   scheduler/src/test/resources/startup.properties 2e938ee 
>   scheduler/src/test/resources/statestore.credentials PRE-CREATION 
>   scheduler/src/test/resources/statestore.properties PRE-CREATION 
>   src/conf/startup.properties ef0a2d5 
>   src/conf/statestore.properties PRE-CREATION 
>   webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java
5001fe6 
>   webapp/src/test/resources/statestore.properties PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41605/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing done
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message