falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 41505: FALCON-1661 : Similar timestamp is getting added for Falcon instance vertex in GraphDB
Date Wed, 23 Dec 2015 04:22:48 GMT


> On Dec. 21, 2015, 10:26 a.m., Ajay Yadava wrote:
> > It seems that you are changing the same column to now contain nominal time, won't
that be a backward incompatible change? I was thinking more on lines of adding nominal time
also rather than changing the existing timestamp.
> 
> Peeyush Bishnoi wrote:
>     I don't think so that this is a backward incompatible change. Initially I have thought
of adding nominal time as new property to vertex but on more closure look around test cases,
I found that it should be nominal time for existing timestamp rather than actual time.

Thanks for clarifying @Peeyush Bishnoi. From what you are telling it seems that's how it was
intended to be but not implemented and hence a bug. Can you please point me to the relevant
test cases which helped you reach the conclusion? I will also take a second look.


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41505/#review111450
-----------------------------------------------------------


On Dec. 18, 2015, 6:48 a.m., Peeyush Bishnoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41505/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2015, 6:48 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1661
>     https://issues.apache.org/jira/browse/FALCON-1661
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Similar timestamp is getting added for Falcon instance vertex in GraphDB
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java
b709857 
>   common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java f206ff1

>   common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 29f933d

> 
> Diff: https://reviews.apache.org/r/41505/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message