falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peeyush Bishnoi" <bpeey...@yahoo.co.in>
Subject Re: Review Request 41505: FALCON-1661 : Similar timestamp is getting added for Falcon instance vertex in GraphDB
Date Fri, 18 Dec 2015 06:47:29 GMT


> On Dec. 17, 2015, 5:16 p.m., Balu Vellanki wrote:
> > common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java, line
193
> > <https://reviews.apache.org/r/41505/diff/1/?file=1168538#file1168538line193>
> >
> >     getTimeStampAsLong() and getNominalTimeStampAsLong() can be made into a single
method to avoid code repetition.

Fixed


- Peeyush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41505/#review110968
-----------------------------------------------------------


On Dec. 17, 2015, 11:20 a.m., Peeyush Bishnoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41505/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2015, 11:20 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1661
>     https://issues.apache.org/jira/browse/FALCON-1661
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Similar timestamp is getting added for Falcon instance vertex in GraphDB
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java
b709857 
>   common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java f206ff1

>   common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 29f933d

> 
> Diff: https://reviews.apache.org/r/41505/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message