falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Balu Vellanki" <bvella...@hortonworks.com>
Subject Re: Review Request 41464: FALCON-1645 : Database export
Date Thu, 17 Dec 2015 17:20:43 GMT


> On Dec. 17, 2015, 2:17 a.m., Ying Zheng wrote:
> > common/src/test/resources/config/feed/feed-export-0.1.xml, line 55
> > <https://reviews.apache.org/r/41464/diff/1/?file=1167005#file1167005line55>
> >
> >     According to my understanding, the element "Locations" can be removed since
you already define it below "clusters". Correct me if I am wrong. Same for the other test
xml.

Feed can have different locations for source and target clusters. The locations defined outside
the "clusters" is the default. So I think having "locations" within cluster is ok.


- Balu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41464/#review110837
-----------------------------------------------------------


On Dec. 16, 2015, 8:12 p.m., Venkatesan Ramachandran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41464/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2015, 8:12 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Ability to export to database
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/LifeCycle.java d4d39e8 
>   client/src/main/java/org/apache/falcon/Tag.java 5027ac0 
>   client/src/main/resources/feed-0.1.xsd 2974dd6 
>   common/src/main/java/org/apache/falcon/entity/DatasourceHelper.java f9b3966 
>   common/src/main/java/org/apache/falcon/entity/EntityUtil.java 66dba6f 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java 18d5152 
>   common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java 0b48e66

>   common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java f206ff1

>   common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 98cdf6b 
>   common/src/test/java/org/apache/falcon/entity/parser/FeedEntityParserTest.java a583f52

>   common/src/test/java/org/apache/falcon/entity/v0/EntityGraphTest.java f49362f 
>   common/src/test/resources/config/feed/feed-export-0.1.xml PRE-CREATION 
>   common/src/test/resources/config/feed/feed-export-exclude-fields-0.1.xml PRE-CREATION

>   oozie/src/main/java/org/apache/falcon/oozie/DatabaseExportWorkflowBuilder.java PRE-CREATION

>   oozie/src/main/java/org/apache/falcon/oozie/DatabaseImportWorkflowBuilder.java 45f46d7

>   oozie/src/main/java/org/apache/falcon/oozie/ExportWorkflowBuilder.java PRE-CREATION

>   oozie/src/main/java/org/apache/falcon/oozie/FeedExportCoordinatorBuilder.java PRE-CREATION

>   oozie/src/main/java/org/apache/falcon/oozie/FeedImportCoordinatorBuilder.java 70289d0

>   oozie/src/main/java/org/apache/falcon/oozie/OozieCoordinatorBuilder.java b1db186 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java
026f79f 
>   oozie/src/main/java/org/apache/falcon/oozie/feed/FeedBundleBuilder.java 9fbc5b2 
>   oozie/src/main/resources/action/feed/export-sqoop-database-action.xml PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/41464/diff/
> 
> 
> Testing
> -------
> 
> Manual testing
> Unit tests
> 
> 
> Thanks,
> 
> Venkatesan Ramachandran
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message