falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karishma Gulati" <gulati.karis...@yahoo.com>
Subject Re: Review Request 40779: [Falcon-1377] Add tests in falcon for the Triage API
Date Thu, 17 Dec 2015 14:50:52 GMT


> On Nov. 30, 2015, 2:40 p.m., PRAGYA MITTAL wrote:
> > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java,
line 51
> > <https://reviews.apache.org/r/40779/diff/1/?file=1148010#file1148010line51>
> >
> >     inputDataRoot and outputDataRoot ?

We need to delete all test data (created for input and output feeds) as well, which wasn't
getting deleted earlier. All our feed templates have these directories as their default data
path.


> On Nov. 30, 2015, 2:40 p.m., PRAGYA MITTAL wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java,
line 536
> > <https://reviews.apache.org/r/40779/diff/1/?file=1148011#file1148011line536>
> >
> >     Add to AssertUtil.

It's a very test logic specific assertion.


- Karishma


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40779/#review108314
-----------------------------------------------------------


On Dec. 17, 2015, 2:50 p.m., Karishma Gulati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40779/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2015, 2:50 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Add tests for the feature explained in https://issues.apache.org/jira/browse/FALCON-796
- Enable users to triage data processing issues through falcon.
> As part of this patch, will add tests corresponding to single colo processing. Cross-colo
instance triage tests wil be added in a separate class as part of a separate patch.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java
921a303 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java
3d05ae9 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java
00ef79d 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40779/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Karishma Gulati
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message