falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "pavan kumar kolamuri" <pavan.kolam...@gmail.com>
Subject Re: Review Request 41396: FALCON-1635: Migration of EntityManagerPaginationJerseyIT and EntityManagerJerseySmokeIT to use falcon unit
Date Wed, 16 Dec 2015 17:24:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41396/#review110680
-----------------------------------------------------------



webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java (line
133)
<https://reviews.apache.org/r/41396/#comment170716>

    Can't you use StringUtils in commons lang3. so that we can avoid package name here ?



webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java (line
136)
<https://reviews.apache.org/r/41396/#comment170717>

    As part of falcon unit setup we should have already done this. Can you please check



webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseySmokeIT.java (line 120)
<https://reviews.apache.org/r/41396/#comment170723>

    Can't we move createTestData to AbstractSchedulableManagerJerseyIT



webapp/src/test/java/org/apache/falcon/util/OozieTestUtils.java (line 102)
<https://reviews.apache.org/r/41396/#comment170726>

    Here we can combine few methods, instead of taking  argument as UnitTestContext and TestContext
separately can we take argument AbstractTestContext and simplify functions.


- pavan kumar kolamuri


On Dec. 16, 2015, 4:39 p.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41396/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2015, 4:39 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1635
>     https://issues.apache.org/jira/browse/FALCON-1635
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> In this jira, we migrate EntityManagerPaginationJerseyIT and EntityManagerJerseySmokeIT
using falcon unit.
> 
> 
> Diffs
> -----
> 
>   webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java
f5bcc54 
>   webapp/src/test/java/org/apache/falcon/resource/AbstractTestContext.java PRE-CREATION

>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 258bb1a

>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseySmokeIT.java 2bedb88

>   webapp/src/test/java/org/apache/falcon/resource/EntitySchedulerManagerJerseyIT.java
35119f0 
>   webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java
7959b63 
>   webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java f94bd8c

>   webapp/src/test/java/org/apache/falcon/resource/TestContext.java 0697b3d 
>   webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java 1d3167b 
>   webapp/src/test/java/org/apache/falcon/util/OozieTestUtils.java 056c0a1 
> 
> Diff: https://reviews.apache.org/r/41396/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message