falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "sandeep samudrala" <sandys...@gmail.com>
Subject Re: Review Request 41400: Add test for SLA monitoring API
Date Wed, 16 Dec 2015 06:59:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41400/#review110624
-----------------------------------------------------------



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLAMonitoring.java
(line 118)
<https://reviews.apache.org/r/41400/#comment170588>

    oldInputFeedName? baseFeedName is more  appropriate?



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLAMonitoring.java
(line 119)
<https://reviews.apache.org/r/41400/#comment170593>

    no Process here to denote it as input.
    feedFrequencies.



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLAMonitoring.java
(line 184)
<https://reviews.apache.org/r/41400/#comment170620>

    10 minutes is too long, reduce it.



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLAMonitoring.java
(line 203)
<https://reviews.apache.org/r/41400/#comment170624>

    Can you add a case to check for instance of a feed where there is no _SUCCESS flag to
check for sla upon directory creation?



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLAMonitoring.java
(line 212)
<https://reviews.apache.org/r/41400/#comment170626>

    Create separate methods for different tests,(deletion, creation, validation with and without
_SUCCESS flag).


- sandeep samudrala


On Dec. 15, 2015, 2:48 p.m., PRAGYA MITTAL wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41400/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 2:48 p.m.)
> 
> 
> Review request for Falcon and Ajay Yadava.
> 
> 
> Bugs: FALCON-1566
>     https://issues.apache.org/jira/browse/FALCON-1566
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Add test for SLA monitoring API
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java
e406cae 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/ServiceResponse.java
55e862c 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java
ccd083b 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java
28ddbd7 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessSLATest.java
f4c9b30 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLAMonitoring.java
PRE-CREATION 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLATest.java
PRE-CREATION 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/ProcessSLATest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41400/diff/
> 
> 
> Testing
> -------
> 
> Tetsed in distributed mode.
> 
> 
> Thanks,
> 
> PRAGYA MITTAL
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message