falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "pavan kumar kolamuri" <pavan.kolam...@gmail.com>
Subject Re: Review Request 40769: Integration tests for Falcon Native Scheduler
Date Tue, 15 Dec 2015 09:31:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40769/#review110456
-----------------------------------------------------------



unit/src/test/java/org/apache/falcon/unit/examples/JavaHelloWorldExample.java (line 23)
<https://reviews.apache.org/r/40769/#comment170361>

    I am still not convinced with adding documentation  for simple HelloWorld class of java.
Just by looking this users will understand it is helloworld example of java. It can be used
across multiple tests in multiple use cases, though currently it might be used by simple Java
Action in Falcon unit. Anyway will add doc for the same.



webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java (line
75)
<https://reviews.apache.org/r/40769/#comment170362>

    Ok will refactor it


- pavan kumar kolamuri


On Dec. 14, 2015, 7:26 a.m., pavan kumar kolamuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40769/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2015, 7:26 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/FALCON-1447
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FALCON-1447
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> For Native Scheduler we have tests where all services are mocked and even jobs are not
scheduled in oozie. Integration tests are needed for Native Scheduler to run from end to end.
> 
> 
> Diffs
> -----
> 
>   oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java f6e87c4 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 2f97c0d 
>   scheduler/pom.xml 336997d 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
ac7cde8 
>   scheduler/src/test/java/org/apache/falcon/state/AbstractSchedulerTestBase.java 48c1426

>   unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 9eb4277 
>   unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java 0065c71

>   unit/src/main/resources/oozie-site.xml 23d41eb 
>   unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 2a73516 
>   unit/src/test/java/org/apache/falcon/unit/examples/JavaHelloWorldExample.java PRE-CREATION

>   webapp/pom.xml 428f67e 
>   webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java
PRE-CREATION 
>   webapp/src/test/java/org/apache/falcon/resource/EntitySchedulerManagerJerseyIT.java
PRE-CREATION 
>   webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java
PRE-CREATION 
>   webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 6458b59

>   webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java 1d49353 
>   webapp/src/test/resources/helloworldworkflow.xml PRE-CREATION 
>   webapp/src/test/resources/local-process-noinputs-template.xml PRE-CREATION 
>   webapp/src/test/resources/runtime.properties 1da0ca7 
>   webapp/src/test/resources/startup.properties 756f315 
> 
> Diff: https://reviews.apache.org/r/40769/diff/
> 
> 
> Testing
> -------
> 
> These are test cases itself
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message