falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 41339: FALCON-1617: Enable SLA monitoring for instances in past
Date Mon, 14 Dec 2015 17:17:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41339/#review110257
-----------------------------------------------------------



common/src/main/java/org/apache/falcon/entity/FeedHelper.java (line 1013)
<https://reviews.apache.org/r/41339/#comment170072>

    Write a helper method for calculating frequency for old retention. Logic is as below:
    
    ```
    Frequency entityFrequency = entity.getFrequency();
            Frequency defaultFrequency = new Frequency("hours(24)");
            if (DateUtil.getFrequencyInMillis(entityFrequency) < DateUtil.getFrequencyInMillis(defaultFrequency))
{
                coord.setFrequency("${coord:hours(6)}");
            } else {
                coord.setFrequency("${coord:days(1)}");
            }
            
            ```



common/src/main/java/org/apache/falcon/entity/FeedHelper.java (line 1017)
<https://reviews.apache.org/r/41339/#comment170071>

    @Narayan,
    
    the way this part is currently written is not correct. You need to use the existing method
to getLifeCycleRetentionFrequency and if that is null, then write another helper method(shown
above) to calculate retention Frequency for old method.



common/src/main/java/org/apache/falcon/entity/FeedHelper.java (line 1021)
<https://reviews.apache.org/r/41339/#comment170069>

    @Narayan
    getLimit is not same as frequency, it's a frequency like expression used for specifying
retention period but it is not same as frequency.



prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java (line 330)
<https://reviews.apache.org/r/41339/#comment170073>

    I think your code is not rebased on the latest patch. This method has been renamed.



prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java (line 331)
<https://reviews.apache.org/r/41339/#comment170075>

    You need to handle both lifecycle frequency and old frequency here.


- Ajay Yadava


On Dec. 14, 2015, 10:17 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41339/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2015, 10:17 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1617
>     https://issues.apache.org/jira/browse/FALCON-1617
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Currently on enabling SLA monitoring it doesn't consider instances which had nominal
time in past for SLA monitoring. With this JIRA we would like to enable this.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java 29daff3 
>   prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java b302539

> 
> Diff: https://reviews.apache.org/r/41339/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message