falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "pavan kumar kolamuri" <pavan.kolam...@gmail.com>
Subject Re: Review Request 41256: MySql Support for Native Scheduler
Date Mon, 14 Dec 2015 12:46:13 GMT


> On Dec. 11, 2015, 12:12 p.m., Ajay Yadava wrote:
> > src/bin/falcon-db.sh, line 49
> > <https://reviews.apache.org/r/41256/diff/2/?file=1160109#file1160109line49>
> >
> >     Will logs/ directory be a better choice, so that all logs are available in one
place?
> 
> pavan kumar kolamuri wrote:
>     Logs will still go to logs directory itself.
> 
> Ajay Yadava wrote:
>     May be I am missing something. Can you please explain what is this value("falcon.log.dir")
being used for and what will be the value of $HOME when it is executed?

falcon.log.dir is logging directory path. please src/bin/falcon has configured this property


> On Dec. 11, 2015, 12:12 p.m., Ajay Yadava wrote:
> > src/conf/startup.properties, line 56
> > <https://reviews.apache.org/r/41256/diff/2/?file=1160110#file1160110line56>
> >
> >     It will be useful to document a complete sample configuration for using native
scheduler.
> 
> pavan kumar kolamuri wrote:
>     We are adding proper documentation for configuring Native Scheduler and its tracked
in another jira
> 
> Ajay Yadava wrote:
>     We should follow the practice that the code goes along with documentation. It becomes
really hard to track all parts of documentation later on.

Sure will fix it from next time . Currently pallavi already submitted patch for the same.


> On Dec. 11, 2015, 12:12 p.m., Ajay Yadava wrote:
> > pom.xml, line 120
> > <https://reviews.apache.org/r/41256/diff/2/?file=1160106#file1160106line120>
> >
> >     What's the rationale behind choosing this particular version?
> 
> pavan kumar kolamuri wrote:
>     Even oozie uses same version and this version of connector is compatible latest my-sql
server also. i have tested it
> 
> Ajay Yadava wrote:
>     Oozie might have made this decision long back and might not have revisited it. We
shouldn't tie ourselves to same version for this reason. I think we should switch to the most
recent stable version unless there are some other issues.

Sure will change the vesrion. But i tried using this version and connecting to latest mysql
server its working fine.


> On Dec. 11, 2015, 12:12 p.m., Ajay Yadava wrote:
> > scheduler/pom.xml, line 141
> > <https://reviews.apache.org/r/41256/diff/2/?file=1160107#file1160107line141>
> >
> >     I think we should add support for postgres as well.
> 
> Ajay Yadava wrote:
>     Sorry for duplicate comment.
> 
> pavan kumar kolamuri wrote:
>     Its ok. Currently there is need to support for My-sql and derby. If postgres needed
in future , we can add support.
> 
> Ajay Yadava wrote:
>     Can you please raise a JIRA for the same? This should also be clearly documented
that we currently only support MySQL database.

Sure will add documentation


- pavan kumar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41256/#review109948
-----------------------------------------------------------


On Dec. 11, 2015, 11:48 a.m., pavan kumar kolamuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41256/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2015, 11:48 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/FALCON-1658
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FALCON-1658
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Adding mysql support for Statestore db in Native Scheduler. Currently it supports derby
and it was not tested with Mysql
> 
> 
> Diffs
> -----
> 
>   pom.xml 3ad8789 
>   scheduler/pom.xml 336997d 
>   scheduler/src/main/resources/META-INF/persistence.xml 86558de 
>   src/bin/falcon-db.sh 415fd5d 
>   src/conf/startup.properties 1694930 
> 
> Diff: https://reviews.apache.org/r/41256/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message