falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 40769: Integration tests for Falcon Native Scheduler
Date Mon, 14 Dec 2015 10:11:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40769/#review110174
-----------------------------------------------------------



oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java (line 96)
<https://reviews.apache.org/r/40769/#comment169946>

    I know it's not part of this JIRA, but we should make the naming consistent between bundle,
coord and oozie client.
    
    getLocalOozieCoordinatorClient etc. I hope it's a very trivial change using IDE refactoring.



unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java (line 128)
<https://reviews.apache.org/r/40769/#comment169950>

    Why are we deleting ```doAsUser``` parameter?



unit/src/test/java/org/apache/falcon/unit/examples/JavaHelloWorldExample.java (line 23)
<https://reviews.apache.org/r/40769/#comment169952>

    Please add more documentation on how to use it and mention some example test cases using
it.



unit/src/test/java/org/apache/falcon/unit/examples/JavaHelloWorldExample.java (line 25)
<https://reviews.apache.org/r/40769/#comment169951>

    



webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java (line
75)
<https://reviews.apache.org/r/40769/#comment169966>

    Why not use submitAndSchedule, since these are not the focus of this test?



webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java (lines
93 - 106)
<https://reviews.apache.org/r/40769/#comment169967>

    This code is repeated for all tests, may be it makes sense to extract them out in @BeforeTest
or another function.


- Ajay Yadava


On Dec. 14, 2015, 7:26 a.m., pavan kumar kolamuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40769/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2015, 7:26 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/FALCON-1447
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FALCON-1447
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> For Native Scheduler we have tests where all services are mocked and even jobs are not
scheduled in oozie. Integration tests are needed for Native Scheduler to run from end to end.
> 
> 
> Diffs
> -----
> 
>   oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java f6e87c4 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 2f97c0d 
>   scheduler/pom.xml 336997d 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
ac7cde8 
>   scheduler/src/test/java/org/apache/falcon/state/AbstractSchedulerTestBase.java 48c1426

>   unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 9eb4277 
>   unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java 0065c71

>   unit/src/main/resources/oozie-site.xml 23d41eb 
>   unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 2a73516 
>   unit/src/test/java/org/apache/falcon/unit/examples/JavaHelloWorldExample.java PRE-CREATION

>   webapp/pom.xml 428f67e 
>   webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java
PRE-CREATION 
>   webapp/src/test/java/org/apache/falcon/resource/EntitySchedulerManagerJerseyIT.java
PRE-CREATION 
>   webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java
PRE-CREATION 
>   webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 6458b59

>   webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java 1d49353 
>   webapp/src/test/resources/helloworldworkflow.xml PRE-CREATION 
>   webapp/src/test/resources/local-process-noinputs-template.xml PRE-CREATION 
>   webapp/src/test/resources/runtime.properties 1da0ca7 
>   webapp/src/test/resources/startup.properties 756f315 
> 
> Diff: https://reviews.apache.org/r/40769/diff/
> 
> 
> Testing
> -------
> 
> These are test cases itself
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message