falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "pavan kumar kolamuri" <pavan.kolam...@gmail.com>
Subject Re: Review Request 40698: FALCON-1512 Implement touch feature for native scheduler
Date Mon, 14 Dec 2015 09:38:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40698/#review110183
-----------------------------------------------------------



scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java (line
353)
<https://reviews.apache.org/r/40698/#comment169959>

    What if process is already ended by that time ? Aren't we giving wrong message ?



scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java (line 382)
<https://reviews.apache.org/r/40698/#comment169960>

    Nit: Missed to correct here


- pavan kumar kolamuri


On Dec. 4, 2015, 12:06 p.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40698/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2015, 12:06 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1512
>     https://issues.apache.org/jira/browse/FALCON-1512
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Touch feature was not implemented for native scheduler. Adding it now.
> 
> 
> Diffs
> -----
> 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java ebc05ec 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
ac7cde8 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 70c8353

>   scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java 087114f 
> 
> Diff: https://reviews.apache.org/r/40698/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done. Couldn't add UTs are there are interactions with Oozie.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message