falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "pavan kumar kolamuri" <pavan.kolam...@gmail.com>
Subject Re: Review Request 41256: MySql Support for Native Scheduler
Date Fri, 11 Dec 2015 12:34:37 GMT


> On Dec. 11, 2015, 12:12 p.m., Ajay Yadava wrote:
> > pom.xml, line 120
> > <https://reviews.apache.org/r/41256/diff/2/?file=1160106#file1160106line120>
> >
> >     What's the rationale behind choosing this particular version?

Even oozie uses same version and this version of connector is compatible latest my-sql server
also. i have tested it


> On Dec. 11, 2015, 12:12 p.m., Ajay Yadava wrote:
> > scheduler/pom.xml, line 141
> > <https://reviews.apache.org/r/41256/diff/2/?file=1160107#file1160107line141>
> >
> >     I think we should add support for postgres as well.
> 
> Ajay Yadava wrote:
>     Sorry for duplicate comment.

Its ok. Currently there is need to support for My-sql and derby. If postgres needed in future
, we can add support.


> On Dec. 11, 2015, 12:12 p.m., Ajay Yadava wrote:
> > scheduler/pom.xml, line 208
> > <https://reviews.apache.org/r/41256/diff/2/?file=1160107#file1160107line208>
> >
> >     Will it make sense to add postgres connectors as well, for users who want to
use postgres?

Explained reason above


> On Dec. 11, 2015, 12:12 p.m., Ajay Yadava wrote:
> > scheduler/src/main/resources/META-INF/persistence.xml, line 50
> > <https://reviews.apache.org/r/41256/diff/2/?file=1160108#file1160108line50>
> >
> >     How can users choose between different db backends (assuming we will add postgres
support as well)?

We are detecting db type by url itself. So users can simply change url path


> On Dec. 11, 2015, 12:12 p.m., Ajay Yadava wrote:
> > src/bin/falcon-db.sh, line 49
> > <https://reviews.apache.org/r/41256/diff/2/?file=1160109#file1160109line49>
> >
> >     Will logs/ directory be a better choice, so that all logs are available in one
place?

Logs will still go to logs directory itself.


> On Dec. 11, 2015, 12:12 p.m., Ajay Yadava wrote:
> > src/conf/startup.properties, line 56
> > <https://reviews.apache.org/r/41256/diff/2/?file=1160110#file1160110line56>
> >
> >     It will be useful to document a complete sample configuration for using native
scheduler.

We are adding proper documentation for configuring Native Scheduler and its tracked in another
jira


> On Dec. 11, 2015, 12:12 p.m., Ajay Yadava wrote:
> > src/conf/startup.properties, line 77
> > <https://reviews.apache.org/r/41256/diff/2/?file=1160110#file1160110line77>
> >
> >     Why is FalconJPAService not required?

It is required and it was moved above


> On Dec. 11, 2015, 12:12 p.m., Ajay Yadava wrote:
> > src/conf/startup.properties, line 97
> > <https://reviews.apache.org/r/41256/diff/2/?file=1160110#file1160110line97>
> >
> >     Can we club this also in the commented section of application.services for native
scheduler?

I tried to club, but FalconJPAService should move up before ConfigurationService and it becoming
messy and finaly decided to made 2 components.


- pavan kumar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41256/#review109948
-----------------------------------------------------------


On Dec. 11, 2015, 11:48 a.m., pavan kumar kolamuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41256/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2015, 11:48 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/FALCON-1658
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FALCON-1658
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Adding mysql support for Statestore db in Native Scheduler. Currently it supports derby
and it was not tested with Mysql
> 
> 
> Diffs
> -----
> 
>   pom.xml 3ad8789 
>   scheduler/pom.xml 336997d 
>   scheduler/src/main/resources/META-INF/persistence.xml 86558de 
>   src/bin/falcon-db.sh 415fd5d 
>   src/conf/startup.properties 1694930 
> 
> Diff: https://reviews.apache.org/r/41256/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message