falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "sandeep samudrala" <sandys...@gmail.com>
Subject Re: Review Request 41198: FALCON-1656 Improve FeedHelper:getRetentionFrequency method
Date Thu, 10 Dec 2015 11:26:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41198/#review109739
-----------------------------------------------------------

Ship it!


Ship It!

- sandeep samudrala


On Dec. 10, 2015, 11:19 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41198/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2015, 11:19 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1656
>     https://issues.apache.org/jira/browse/FALCON-1656
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Improve FeedHelper:getRetentionFrequency method
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java d601c5d 
>   common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java c70f18d

>   common/src/main/java/org/apache/falcon/lifecycle/retention/AgeBasedDelete.java ccb0290

>   common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 3e422fc 
>   lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedCoordinatorBuilder.java
e3e7fec 
> 
> Diff: https://reviews.apache.org/r/41198/diff/
> 
> 
> Testing
> -------
> 
> Unit tests already exist, just a refactoring.
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message