falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peeyush Bishnoi" <bpeey...@yahoo.co.in>
Subject Re: Review Request 40540: Consume Workflow job end notifications for SLA monitoring
Date Wed, 02 Dec 2015 04:53:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40540/#review108603
-----------------------------------------------------------



prism/src/main/java/org/apache/falcon/handler/SLAMonitoringHandler.java (line 40)
<https://reviews.apache.org/r/40540/#comment168064>

    With this Handler service another SLA monitoring service will be provided. Should not
be SLAMonitoringHandler and FeedSLAMonitoringService be part of one service and required functionality
must be achieved.



src/conf/startup.properties (line 94)
<https://reviews.apache.org/r/40540/#comment168062>

    Any particular reason for SLAMonitoringHanlder service to be set for "workflow.execution.listeners"
rather than  "application.services". As this is also one of the service and all the Falcon
services are part of "application.services".


- Peeyush Bishnoi


On Nov. 20, 2015, 12:37 p.m., sandeep samudrala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40540/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2015, 12:37 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1616
>     https://issues.apache.org/jira/browse/FALCON-1616
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> We can leverage workflow job finish notifications and update feed availability so that
SLA monitoring service doesn't need to check for it.
> 
> 
> Diffs
> -----
> 
>   prism/src/main/java/org/apache/falcon/handler/SLAMonitoringHandler.java PRE-CREATION

>   prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java d4383ec

>   prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java ca55d01 
>   src/conf/startup.properties ce6e91f 
> 
> Diff: https://reviews.apache.org/r/40540/diff/
> 
> 
> Testing
> -------
> 
> Unit Tests
> 
> 
> Thanks,
> 
> sandeep samudrala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message