Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A2D0F18E80 for ; Mon, 23 Nov 2015 13:11:14 +0000 (UTC) Received: (qmail 46873 invoked by uid 500); 23 Nov 2015 13:11:14 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 46827 invoked by uid 500); 23 Nov 2015 13:11:14 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 46811 invoked by uid 99); 23 Nov 2015 13:11:14 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Nov 2015 13:11:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 1FCFCC7FD4 for ; Mon, 23 Nov 2015 13:11:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.192 X-Spam-Level: * X-Spam-Status: No, score=1.192 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.588] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id k3jHGZxBE-Kz for ; Mon, 23 Nov 2015 13:11:12 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 0C89220EBA for ; Mon, 23 Nov 2015 13:11:11 +0000 (UTC) Received: (qmail 46673 invoked by uid 99); 23 Nov 2015 13:11:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Nov 2015 13:11:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 0661E2C1F5D for ; Mon, 23 Nov 2015 13:11:11 +0000 (UTC) Date: Mon, 23 Nov 2015 13:11:11 +0000 (UTC) From: "pavan kumar kolamuri (JIRA)" To: dev@falcon.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FALCON-1607) Code refactoring: Refactor ID into more specific sub classes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FALCON-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022075#comment-15022075 ] pavan kumar kolamuri commented on FALCON-1607: ---------------------------------------------- Patch looks good +1 . We need to track of concurrency of process issue if it exists as i said in comments. > Code refactoring: Refactor ID into more specific sub classes > ------------------------------------------------------------ > > Key: FALCON-1607 > URL: https://issues.apache.org/jira/browse/FALCON-1607 > Project: Falcon > Issue Type: Improvement > Reporter: Ajay Yadava > Assignee: Ajay Yadava > Priority: Critical > Fix For: trunk > > Attachments: FALCON-1607.patch > > > Currently the file ID.java is used to uniquely identify various "entities" for native scheduler. This class is overloaded and serves multiple tasks like getting an entity id for an entity and an instance id for an instance. Keeping all this code in one class creates various issues like no check on object creation - one can accidentally call an instance id when the underlying object was supposed to be representing an entity etc. Since ID represents the unique identifier for an instance, entity etc. most methods pass ID and this makes the code hard to reason as we don't know what are we dealing with - an entity or an instance or something else. -- This message was sent by Atlassian JIRA (v6.3.4#6332)