Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1690D18EC1 for ; Wed, 25 Nov 2015 12:50:49 +0000 (UTC) Received: (qmail 6012 invoked by uid 500); 25 Nov 2015 12:50:49 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 5950 invoked by uid 500); 25 Nov 2015 12:50:49 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 5935 invoked by uid 99); 25 Nov 2015 12:50:48 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Nov 2015 12:50:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 424411A21B8 for ; Wed, 25 Nov 2015 12:50:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.649 X-Spam-Level: **** X-Spam-Status: No, score=4.649 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.554, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id XWhRkrLC7xr9 for ; Wed, 25 Nov 2015 12:50:38 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 496CE20229 for ; Wed, 25 Nov 2015 12:50:37 +0000 (UTC) Received: (qmail 5784 invoked by uid 99); 25 Nov 2015 12:50:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Nov 2015 12:50:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D5D5D2E439A; Wed, 25 Nov 2015 12:50:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0402923902173216444==" MIME-Version: 1.0 Subject: Re: Review Request 39588: State Store for instances scheduled by Falcon Native Scheduler From: "pavan kumar kolamuri" To: "pavan kumar kolamuri" , "Falcon" , "Ajay Yadava" Date: Wed, 25 Nov 2015 12:50:34 -0000 Message-ID: <20151125125034.26797.26832@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "pavan kumar kolamuri" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39588/ X-Sender: "pavan kumar kolamuri" References: <20151104184449.17556.17110@reviews.apache.org> In-Reply-To: <20151104184449.17556.17110@reviews.apache.org> Reply-To: "pavan kumar kolamuri" X-ReviewRequest-Repository: falcon-git --===============0402923902173216444== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Nov. 4, 2015, 6:44 p.m., Ajay Yadava wrote: > > scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java, line 105 > > > > > > No need to override if you are inheriting the same behavior, right? > > pavan kumar kolamuri wrote: > Yes we will discuss this with you offline We have removed this during refactor - pavan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39588/#review105038 ----------------------------------------------------------- On Nov. 25, 2015, 11:52 a.m., pavan kumar kolamuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39588/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2015, 11:52 a.m.) > > > Review request for Falcon. > > > Bugs: https://issues.apache.org/jira/browse/FALCON-1234 > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FALCON-1234 > > > Repository: falcon-git > > > Description > ------- > > Persistent State Store for Falcon Native Scheduler > > > Diffs > ----- > > checkstyle/src/main/resources/falcon/checkstyle.xml 2130e73 > checkstyle/src/main/resources/falcon/findbugs-exclude.xml 0a7580d > common/src/main/resources/startup.properties cc5212a > pom.xml fad8902 > scheduler/pom.xml 20a91d2 > scheduler/src/main/java/org/apache/falcon/execution/ExecutionInstance.java 2d6b67d > scheduler/src/main/java/org/apache/falcon/execution/FalconExecutionService.java b48a65b > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java 434f168 > scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java fb4c8c9 > scheduler/src/main/java/org/apache/falcon/state/EntityState.java 15aea9a > scheduler/src/main/java/org/apache/falcon/state/InstanceID.java a722be9 > scheduler/src/main/java/org/apache/falcon/state/InstanceState.java ada9d2b > scheduler/src/main/java/org/apache/falcon/state/StateService.java c1671ac > scheduler/src/main/java/org/apache/falcon/state/store/AbstractStateStore.java e36f85c > scheduler/src/main/java/org/apache/falcon/state/store/EntityStateStore.java 113f4c5 > scheduler/src/main/java/org/apache/falcon/state/store/InMemoryStateStore.java 52b3bb8 > scheduler/src/main/java/org/apache/falcon/state/store/InstanceStateStore.java 483d9e6 > scheduler/src/main/java/org/apache/falcon/state/store/StateStore.java f595c26 > scheduler/src/main/java/org/apache/falcon/state/store/jdbc/BeanMapperUtil.java PRE-CREATION > scheduler/src/main/java/org/apache/falcon/state/store/jdbc/EntityBean.java PRE-CREATION > scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java PRE-CREATION > scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java PRE-CREATION > scheduler/src/main/java/org/apache/falcon/state/store/service/FalconJPAService.java PRE-CREATION > scheduler/src/main/java/org/apache/falcon/tools/FalconStateStoreDBCLI.java PRE-CREATION > scheduler/src/main/resources/META-INF/persistence.xml PRE-CREATION > scheduler/src/main/resources/falcon-buildinfo.properties PRE-CREATION > scheduler/src/test/java/org/apache/falcon/execution/FalconExecutionServiceTest.java bff92c9 > scheduler/src/test/java/org/apache/falcon/notification/service/SchedulerServiceTest.java 001f466 > scheduler/src/test/java/org/apache/falcon/state/AbstractSchedulerTestBase.java PRE-CREATION > scheduler/src/test/java/org/apache/falcon/state/EntityStateServiceTest.java 2f32b43 > scheduler/src/test/java/org/apache/falcon/state/InstanceStateServiceTest.java 43c3c54 > scheduler/src/test/java/org/apache/falcon/state/service/TestFalconJPAService.java PRE-CREATION > scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java PRE-CREATION > scheduler/src/test/java/org/apache/falcon/tools/TestFalconStateStoreDBCLI.java PRE-CREATION > scheduler/src/test/resources/startup.properties PRE-CREATION > src/bin/falcon-db.sh PRE-CREATION > src/conf/startup.properties ce6e91f > src/main/assemblies/distributed-package.xml 794eaef > src/main/assemblies/standalone-package.xml fcff8d7 > unit/src/main/resources/startup.properties fe6f430 > > Diff: https://reviews.apache.org/r/39588/diff/ > > > Testing > ------- > > I have written unit tests. I will also test externally by setting up everything > > > Thanks, > > pavan kumar kolamuri > > --===============0402923902173216444==--