Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@falcon.apache.org
Content-Type: multipart/alternative;
 boundary="===============6331999026867020292=="
MIME-Version: 1.0
Subject: Re: Review Request 39844: FALCON-1233 Support co-existence of Oozie
 scheduler (coord) and Falcon native scheduler.
From: "Pallavi Rao" <pallavi.rao@inmobi.com>
To: "Peeyush Bishnoi" <bpeeyush@yahoo.co.in>,
 "Falcon" <dev@falcon.incubator.apache.org>,
 "Pallavi Rao" <pallavi.rao@inmobi.com>
Date: Wed, 25 Nov 2015 06:33:39 -0000
Message-ID: <20151125063339.24387.8152@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Pallavi Rao" <noreply@reviews.apache.org>
References: <20151120065343.1027.75437@reviews.apache.org>
In-Reply-To: <20151120065343.1027.75437@reviews.apache.org>
Reply-To: "Pallavi Rao" <pallavi.rao@inmobi.com>

--===============6331999026867020292==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Nov. 20, 2015, 6:53 a.m., Peeyush Bishnoi wrote:
> > common/src/main/java/org/apache/falcon/workflow/WorkflowEngineFactory.java, line 46
> > <https://reviews.apache.org/r/39844/diff/1/?file=1114449#file1114449line46>
> >
> >     Any particular reason for naming WF Engine PRIMARY and SECONDARY.

Yep. confusing. Addressed in the new patch.


- Pallavi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39844/#review107316
-----------------------------------------------------------


On Nov. 25, 2015, 6:32 a.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39844/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 6:32 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1233
>     https://issues.apache.org/jira/browse/FALCON-1233
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> The migration to Falcon native scheduler should be as seamless as possible and the user should be able to migrate to the native scheduler in a phased manner (entity by entity).
> 
> This patch introduces the notion of primary and secondary workflow engines. It allows users to schedule an entity on the secondary engine (primary, by default). The idea is that initially, users will use Falcon native scheduler as the secondary engine to migrate their entities one by one. When most entities have been migrated, the Oozie scheduler becomes secondary (and eventually removed).
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/workflow/WorkflowEngineFactory.java 49592ac 
>   common/src/main/java/org/apache/falcon/workflow/WorkflowJobEndNotificationService.java 9d96fa3 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java 7b36b11 
>   docs/src/site/twiki/falconcli/Schedule.twiki 42192c7 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 724f646 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 16ef83a 
>   prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java fea2989 
>   prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java d317aa1 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java d7d157f 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java ca2010b 
>   scheduler/src/test/java/org/apache/falcon/execution/FalconExecutionServiceTest.java bff92c9 
>   scheduler/src/test/java/org/apache/falcon/workflow/engine/WorkflowEngineFactoryTest.java PRE-CREATION 
>   unit/pom.xml 8d9f443 
> 
> Diff: https://reviews.apache.org/r/39844/diff/
> 
> 
> Testing
> -------
> 
> UTs added. Manual testing done.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>


--===============6331999026867020292==--