Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@falcon.apache.org
Content-Type: multipart/alternative;
 boundary="===============6305567139604741199=="
MIME-Version: 1.0
Subject: Re: Review Request 39810: FALCON-1552: Migration of
 ProcessInstanceManagerIT to use falcon unit
From: "Pallavi Rao" <pallavi.rao@inmobi.com>
To: "Narayan Periwal" <narayan.periwal@inmobi.com>,
 "Falcon" <dev@falcon.incubator.apache.org>,
 "Pallavi Rao" <pallavi.rao@inmobi.com>
Date: Wed, 04 Nov 2015 07:10:28 -0000
Message-ID: <20151104071028.28714.35684@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Pallavi Rao" <noreply@reviews.apache.org>
References: <20151030091735.22462.33197@reviews.apache.org>
In-Reply-To: <20151030091735.22462.33197@reviews.apache.org>
Reply-To: "Pallavi Rao" <pallavi.rao@inmobi.com>

--===============6305567139604741199==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39810/#review105039
-----------------------------------------------------------


webapp/pom.xml (line 92)
<https://reviews.apache.org/r/39810/#comment163402>

    Should only be a test dependency.


webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java (line 22)
<https://reviews.apache.org/r/39810/#comment163403>

    You should be using hadoop.FileSystem. If you use JailedFileSystem directly, we won't be able to run the test in "cluster" mode.


webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java (line 51)
<https://reviews.apache.org/r/39810/#comment163405>

    As mentioned before, don't use implementations. Use interfaces instead, so you we can run these tests in cluster mode sometime in the future.


webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java (line 201)
<https://reviews.apache.org/r/39810/#comment163409>

    This test should schedule more than 1 instance, else what is point in testing pagination.


webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java (line 28)
<https://reviews.apache.org/r/39810/#comment163410>

    Use interface, please.


- Pallavi Rao


On Oct. 30, 2015, 9:17 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39810/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2015, 9:17 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: falcon-1552
>     https://issues.apache.org/jira/browse/falcon-1552
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> As Integration tests are flaky, we have a plan of migrating some integration tests using falcon unit. As part of this, we migrate ProcessInstanceManagerIT using falcon unit in this jira
> 
> 
> Diffs
> -----
> 
>   webapp/pom.xml 0999c36 
>   webapp/src/test/java/org/apache/falcon/examples/JavaSleepExample.java PRE-CREATION 
>   webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java ffc203e 
>   webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java PRE-CREATION 
>   webapp/src/test/resources/local-cluster-template.xml PRE-CREATION 
>   webapp/src/test/resources/sleepWorkflow.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39810/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


--===============6305567139604741199==--