Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E056B18002 for ; Tue, 3 Nov 2015 13:54:01 +0000 (UTC) Received: (qmail 12354 invoked by uid 500); 3 Nov 2015 13:54:01 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 12309 invoked by uid 500); 3 Nov 2015 13:54:01 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 12298 invoked by uid 99); 3 Nov 2015 13:54:01 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Nov 2015 13:54:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 3A6EFC0098 for ; Tue, 3 Nov 2015 13:54:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 5.429 X-Spam-Level: ***** X-Spam-Status: No, score=5.429 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.008, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Ivb7T4jLv28c for ; Tue, 3 Nov 2015 13:54:00 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id 382C22386D for ; Tue, 3 Nov 2015 13:54:00 +0000 (UTC) Received: (qmail 12281 invoked by uid 99); 3 Nov 2015 13:54:00 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Nov 2015 13:54:00 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B65DD1DB253; Tue, 3 Nov 2015 13:53:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5235958070752397213==" MIME-Version: 1.0 Subject: Re: Review Request 39812: FACLON-1573 - Supply user-defined properties to Oozie workflows during schedule From: "Ajay Yadava" To: "Daniel del Castillo" , "Falcon" , "Ajay Yadava" Date: Tue, 03 Nov 2015 13:53:58 -0000 Message-ID: <20151103135358.16291.10995@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Ajay Yadava" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39812/ X-Sender: "Ajay Yadava" References: <20151030115329.22462.81921@reviews.apache.org> In-Reply-To: <20151030115329.22462.81921@reviews.apache.org> Reply-To: "Ajay Yadava" X-ReviewRequest-Repository: falcon-git --===============5235958070752397213== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39812/#review104910 ----------------------------------------------------------- This is a very useful feature and it will be really helpful to document these options in schedule api with an example. - Ajay Yadava On Oct. 30, 2015, 11:53 a.m., Daniel del Castillo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39812/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2015, 11:53 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1573 > https://issues.apache.org/jira/browse/FALCON-1573 > > > Repository: falcon-git > > > Description > ------- > > Make user-defined properties passed in the entity sechdule service available in the configuration of the coordinator job so they can be used in the workflow. Please see Jira ticket for further details. > > > Diffs > ----- > > oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java e0af30deb355b58ad8edab5b1fd7129944838ac8 > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 09c29abccfa298e3ef02f2bd4250f4ed17bf2cbc > oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java 5e930272864aebe44cae0eea2eb85977fbeeb6cf > oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java 9f492d7b22001dd016e5d2ca12909d84d3a0c5f4 > > Diff: https://reviews.apache.org/r/39812/diff/ > > > Testing > ------- > > UT added. > Manual functional testing done. > > > Thanks, > > Daniel del Castillo > > --===============5235958070752397213==--