falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "PRAGYA MITTAL" <mittal.pragy...@gmail.com>
Subject Re: Review Request 40779: [Falcon-1377] Add tests in falcon for the Triage API
Date Mon, 30 Nov 2015 14:40:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40779/#review108314
-----------------------------------------------------------



falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java
(line 324)
<https://reviews.apache.org/r/40779/#comment167716>

    Is it required ?



falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java
(line 51)
<https://reviews.apache.org/r/40779/#comment167732>

    inputDataRoot and outputDataRoot ?



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
(line 93)
<https://reviews.apache.org/r/40779/#comment167751>

    Merge the test cases as one and try passing the variables using DataProvider.



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
(line 94)
<https://reviews.apache.org/r/40779/#comment167728>

    embedded group ?
    Will this test not run in distributed mode ?



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
(line 97)
<https://reviews.apache.org/r/40779/#comment167729>

    Change date to some time in 2015. Giving entities of 2010 is not a best practise ?



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
(line 114)
<https://reviews.apache.org/r/40779/#comment167753>

    Can it be global ?



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
(line 115)
<https://reviews.apache.org/r/40779/#comment167754>

    Can it be global ?



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
(line 139)
<https://reviews.apache.org/r/40779/#comment167733>

    See the comment above ?



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
(line 180)
<https://reviews.apache.org/r/40779/#comment167734>

    See the comment above ?



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
(line 226)
<https://reviews.apache.org/r/40779/#comment167735>

    See the comment above ?



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
(line 272)
<https://reviews.apache.org/r/40779/#comment167736>

    See the comment above ?



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
(line 289)
<https://reviews.apache.org/r/40779/#comment167737>

    See the comment above ?



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
(line 306)
<https://reviews.apache.org/r/40779/#comment167738>

    See the comment above ?



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
(line 323)
<https://reviews.apache.org/r/40779/#comment167739>

    See the comment above ?



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
(line 340)
<https://reviews.apache.org/r/40779/#comment167740>

    See the comment above ?



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
(line 359)
<https://reviews.apache.org/r/40779/#comment167741>

    See the comment above ?



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
(line 382)
<https://reviews.apache.org/r/40779/#comment167742>

    See the comment above ?



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
(line 412)
<https://reviews.apache.org/r/40779/#comment167743>

    See the comment above ?



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
(line 484)
<https://reviews.apache.org/r/40779/#comment167744>

    See the comment above ?



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
(line 536)
<https://reviews.apache.org/r/40779/#comment167750>

    Add to AssertUtil.



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
(line 537)
<https://reviews.apache.org/r/40779/#comment167749>

    Java doc ?



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
(line 541)
<https://reviews.apache.org/r/40779/#comment167747>

    Since thsi is a generic method add this to InstanceUtil so that other test cases can also
use it.



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
(line 542)
<https://reviews.apache.org/r/40779/#comment167745>

    Add Java doc.



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
(line 562)
<https://reviews.apache.org/r/40779/#comment167748>

    See the comment above.



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
(line 563)
<https://reviews.apache.org/r/40779/#comment167746>

    Add Java doc.


- PRAGYA MITTAL


On Nov. 27, 2015, 6:26 p.m., Karishma Gulati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40779/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2015, 6:26 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Add tests for the feature explained in https://issues.apache.org/jira/browse/FALCON-796
- Enable users to triage data processing issues through falcon.
> As part of this patch, will add tests corresponding to single colo processing. Cross-colo
instance triage tests wil be added in a separate class as part of a separate patch.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java
67d9ee2 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java
921a303 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java
00ef79d 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40779/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Karishma Gulati
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message