falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "PRAGYA MITTAL" <mittal.pragy...@gmail.com>
Subject Re: Review Request 39477: [FALCON-1533] Migrate to object entity representation
Date Mon, 30 Nov 2015 12:36:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39477/#review108310
-----------------------------------------------------------



falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/Brother.java
(line 34)
<https://reviews.apache.org/r/39477/#comment167706>

    As you are already following naming conventions,to avoid confusion name the object as
'entity' instead of 'data'.


- PRAGYA MITTAL


On Nov. 3, 2015, 6:44 p.m., Paul Isaychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39477/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 6:44 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1533
>     https://issues.apache.org/jira/browse/FALCON-1533
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Now all entities are represented as strings. We have a lot of places where we wrap that
string into object and after some changes revert it back to string.
> Working with objects have much more advantages.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ClusterMerlin.java
fe1338a 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java
ba1d228 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java
7607aa6 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java
67d9ee2 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java
e406cae 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/ClusterEntityHelper.java
acc01fa 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/FeedEntityHelper.java
437f997 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/ProcessEntityHelper.java
76ad638 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/Brother.java
4330bff 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java
d8df0fb 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java
16ff6cb 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/CleanupUtil.java
a7695fb 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/FileUtil.java
a969f1f 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java
3d05ae9 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java
ae96044 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java
ccd083b 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java
9c37562 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java
7dd3d96 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpCurrentAndLastWeekTest.java
3eb7bed 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELValidationsTest.java
a0922cb 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/EmbeddedPigScriptTest.java
c49c381 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ExternalFSTest.java
728b797 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedClusterUpdateTest.java
feb0cc1 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceListingTest.java
ecb5798 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceStatusTest.java
514fd10 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java
5bb5e6e 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java
6728edf 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedResumeTest.java
ec117d7 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java
28ddbd7 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedScheduleTest.java
79b722a 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedStatusTest.java
d5e8696 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSubmitAndScheduleTest.java
46015dc 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSubmitTest.java
53f3df8 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSuspendTest.java
5217818 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceParamTest.java
33808bf 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceSummaryTest.java
137491d 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/LogMoverTest.java
f936305 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NewRetryTest.java
03bc358 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java
0711e8a 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessFrequencyTest.java
b0480e9 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceColoMixedTest.java
91d39a7 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java
48c8021 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java
d5b4ef2 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceResumeTest.java
b7f4428 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRunningTest.java
98fdcca 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java
6493133 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceSuspendTest.java
f673314 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java
6a12fc8 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLibPathLoadTest.java
8422796 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLibPathTest.java
4196d99 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessSLATest.java
f4c9b30 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessUpdateTest.java
efbb503 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SearchApiTest.java
ee14164 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TouchAPIPrismAndServerTest.java
1bffe9a 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ValidateAPIPrismAndServerTest.java
ca612b8 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/EntitiesPatternSearchTest.java
461b733 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/ListEntitiesTest.java
011d02d 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java
27417bd 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatProcessTest.java
0686081 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatReplicationTest.java
a96b17e 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatRetentionTest.java
d639c21 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDRTest.java
bfc0d66 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDbDRTest.java
5efd69f 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntityLineageTest.java
52cb198 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java
849f67a 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiTest.java
d01b707 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java
7ad4c8e 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListProcessInstancesTest.java
43bdd87 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ProcessPipelineTest.java
bd4b9c2 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/EntityDryRunTest.java
4dc776f 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/FeedDelayTest.java
aaa6ebe 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/NewPrismProcessUpdateTest.java
10ab192 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/OptionalInputTest.java
944c67f 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismClusterDeleteTest.java
f69ccb6 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismConcurrentRequestTest.java
515e97e 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedDeleteTest.java
e8b7ed8 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedLateReplicationTest.java
4864f06 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationPartitionExpTest.java
0a97c89 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationUpdateTest.java
c7d9d2d 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedResumeTest.java
d47a160 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedScheduleTest.java
a7bef6d 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedSnSTest.java
dee8e33 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedSuspendTest.java
c02a28f 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java
ed48265 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessDeleteTest.java
4558646 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessResumeTest.java
85d52bd 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java
2dd602a 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessSnSTest.java
4aa7189 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessSuspendTest.java
e38cc67 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismSubmitTest.java
23878df 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/ProcessPartitionExpVariableTest.java
30b20c5 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RescheduleKilledProcessTest.java
c4fa214 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RescheduleProcessInFinalStatesTest.java
5031de4 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java
8f45d1c 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/UpdateAtSpecificTimeTest.java
c6861ca 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java
5efa5b2 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/EntitiesTableReflectionTest.java
f1ae7b4 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/EntitiesTableTest.java
c53e06b 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/EntityPageTest.java
4ad775e 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java
e18fb47 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/HomePageTest.java
46ace0f 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSourceTargetOptionsTest.java
8bec758 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorTest.java
e99202b 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ProcessSetupTest.java
eae5137 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/AclValidationTest.java
3cb33b6 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ClusterAclTest.java
b799b2c 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/EntityOp.java
dbaae9b 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java
73273f9 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FeedAclTest.java
9259f5e 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ProcessAclTest.java
48cfe54 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java
fe9f565 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/PipelineInstanceDependencyTest.java
81d5fcc 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/ProcessInstanceDependencyTest.java
e93cd36 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/LineageGraphTest.java
dbad9a8 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/ProcessUITest.java
46db977 
> 
> Diff: https://reviews.apache.org/r/39477/diff/
> 
> 
> Testing
> -------
> 
> Testing done.
> 
> 
> Thanks,
> 
> Paul Isaychuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message