falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Narayan Periwal" <narayan.peri...@inmobi.com>
Subject Re: Review Request 40760: Fixing the inconsistencies in the filterBy
Date Fri, 27 Nov 2015 07:16:48 GMT


> On Nov. 27, 2015, 6:26 a.m., Ajay Yadava wrote:
> > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java, line
962
> > <https://reviews.apache.org/r/40760/diff/1/?file=1147813#file1147813line962>
> >
> >     Can you please add a unit test for both the cases?

Yes, I will add it.


- Narayan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40760/#review108194
-----------------------------------------------------------


On Nov. 27, 2015, 6:52 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40760/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2015, 6:52 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1490
>     https://issues.apache.org/jira/browse/FALCON-1490
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> For entity list and summary, the OR is inconsistent within the field CLUSTER and PIPELINES.
Only the first value of these field is being considered for filterBy rather than considering
the OR.
> for example, falcon entity -type process -list -filterBy PIPELINES:lda,PIPELINES:cob
> This will output the process with pipeline=lda. "PIPELINES:cob" is ignored.
> This inconsistency will be fixed as part of this jira.
> 
> 
> Diffs
> -----
> 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 16ef83a 
> 
> Diff: https://reviews.apache.org/r/40760/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message