falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 40760: Support OR in filterBy
Date Fri, 27 Nov 2015 06:26:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40760/#review108194
-----------------------------------------------------------



prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 962)
<https://reviews.apache.org/r/40760/#comment167528>

    Can you please add a unit test for both the cases?


- Ajay Yadava


On Nov. 27, 2015, 6:22 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40760/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2015, 6:22 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1490
>     https://issues.apache.org/jira/browse/FALCON-1490
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> As of now only AND is supported in filterBy, it would be useful to have OR support too
so that users can use filterBy accordingly.
> 
> 
> Diffs
> -----
> 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 16ef83a 
> 
> Diff: https://reviews.apache.org/r/40760/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message