falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pallavi Rao" <pallavi....@inmobi.com>
Subject Re: Review Request 39844: FALCON-1233 Support co-existence of Oozie scheduler (coord) and Falcon native scheduler.
Date Wed, 25 Nov 2015 06:33:35 GMT


> On Nov. 20, 2015, 5:08 a.m., Ajay Yadava wrote:
> > common/src/main/java/org/apache/falcon/workflow/WorkflowEngineFactory.java, line
100
> > <https://reviews.apache.org/r/39844/diff/1/?file=1114449#file1114449line100>
> >
> >     Why is a map required to be sent when we are using only one property?

Just future-proofing. In case we introduce other schedule properties.


> On Nov. 20, 2015, 5:08 a.m., Ajay Yadava wrote:
> > common/src/main/java/org/apache/falcon/workflow/WorkflowEngineFactory.java, line
140
> > <https://reviews.apache.org/r/39844/diff/1/?file=1114449#file1114449line140>
> >
> >     nit: Isn't it already available in WFENGINE.PRIMARY.getEngine()?

Yep.. Will use the cached instance.


> On Nov. 20, 2015, 5:08 a.m., Ajay Yadava wrote:
> > docs/src/site/twiki/FalconCLI.twiki, line 58
> > <https://reviews.apache.org/r/39844/diff/1/?file=1114451#file1114451line58>
> >
> >     Can you please add a little bit of description on the use case for this command?
The name secondary doesn't convey much.

Addressed it.


> On Nov. 20, 2015, 5:08 a.m., Ajay Yadava wrote:
> > common/src/main/java/org/apache/falcon/workflow/WorkflowEngineFactory.java, line
90
> > <https://reviews.apache.org/r/39844/diff/1/?file=1114449#file1114449line90>
> >
> >     nit: can you please log the entity for which it is returned as well?

done.


- Pallavi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39844/#review105231
-----------------------------------------------------------


On Nov. 25, 2015, 6:32 a.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39844/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 6:32 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1233
>     https://issues.apache.org/jira/browse/FALCON-1233
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> The migration to Falcon native scheduler should be as seamless as possible and the user
should be able to migrate to the native scheduler in a phased manner (entity by entity).
> 
> This patch introduces the notion of primary and secondary workflow engines. It allows
users to schedule an entity on the secondary engine (primary, by default). The idea is that
initially, users will use Falcon native scheduler as the secondary engine to migrate their
entities one by one. When most entities have been migrated, the Oozie scheduler becomes secondary
(and eventually removed).
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/workflow/WorkflowEngineFactory.java 49592ac

>   common/src/main/java/org/apache/falcon/workflow/WorkflowJobEndNotificationService.java
9d96fa3 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java
7b36b11 
>   docs/src/site/twiki/falconcli/Schedule.twiki 42192c7 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 724f646

>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 16ef83a 
>   prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java fea2989

>   prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java
d317aa1 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
d7d157f 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java ca2010b

>   scheduler/src/test/java/org/apache/falcon/execution/FalconExecutionServiceTest.java
bff92c9 
>   scheduler/src/test/java/org/apache/falcon/workflow/engine/WorkflowEngineFactoryTest.java
PRE-CREATION 
>   unit/pom.xml 8d9f443 
> 
> Diff: https://reviews.apache.org/r/39844/diff/
> 
> 
> Testing
> -------
> 
> UTs added. Manual testing done.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message