falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pallavi Rao" <pallavi....@inmobi.com>
Subject Re: Review Request 40474: FALCON-1557: Supporting some Entity Management Api's and admin api in Falcon Unit
Date Tue, 24 Nov 2015 04:18:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40474/#review107708
-----------------------------------------------------------



unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java (line 359)
<https://reviews.apache.org/r/40474/#comment166986>

    This will make the string start with a comma, doesn't it? The if condition should be after
the property is appended (In which case you will have to handle the extra comma at the end.)



unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 208)
<https://reviews.apache.org/r/40474/#comment166987>

    Use assertStatus method.



unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 331)
<https://reviews.apache.org/r/40474/#comment166988>

    Call it testEntityList, instead?


- Pallavi Rao


On Nov. 20, 2015, 8:20 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40474/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2015, 8:20 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1557
>     https://issues.apache.org/jira/browse/FALCON-1557
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Entity Management Api's such as summary, list, submitAndSchedule, touch, etc. and admin
api should be supported by Falcon Unit
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 27b93c0 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java c49dd08 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7262964

>   oozie/src/main/java/org/apache/oozie/client/LocalOozieClientCoordProxy.java 093d6ff

>   oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java 6ae92de 
>   prism/src/main/java/org/apache/falcon/resource/admin/AdminResource.java ace21cb 
>   unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 9f2b714 
>   unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java 42adc9a

>   unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 42cb779 
>   unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 2c8642d 
>   webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 8dbbd7d

>   webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java 37442c3 
> 
> Diff: https://reviews.apache.org/r/40474/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message