falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "pavan kumar kolamuri" <pavan.kolam...@gmail.com>
Subject Re: Review Request 40474: FALCON-1557: Supporting some Entity Management Api's and admin api in Falcon Unit
Date Thu, 19 Nov 2015 10:53:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40474/#review107156
-----------------------------------------------------------



unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 73)
<https://reviews.apache.org/r/40474/#comment166116>

    Pls don't change this as it unnecessarily launch lot of instances though might be waiting.



unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 116)
<https://reviews.apache.org/r/40474/#comment166117>

    change here



unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 141)
<https://reviews.apache.org/r/40474/#comment166118>

    here also



unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 190)
<https://reviews.apache.org/r/40474/#comment166119>

    Please change other places also



unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 343)
<https://reviews.apache.org/r/40474/#comment166127>

    Is it possible to check entityName also ?



unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 344)
<https://reviews.apache.org/r/40474/#comment166126>

    Please add different test for summary, as it has lot of functionalities we can add later



unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 350)
<https://reviews.apache.org/r/40474/#comment166125>

    Please add touch in update method, update and touch can be grouped but not here



webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java (line 256)
<https://reviews.apache.org/r/40474/#comment166128>

    did assertInstance method still required as you removed everywhere ?


- pavan kumar kolamuri


On Nov. 19, 2015, 9:40 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40474/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 9:40 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1557
>     https://issues.apache.org/jira/browse/FALCON-1557
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Entity Management Api's such as summary, list, submitAndSchedule, touch, etc. and admin
api should be supported by Falcon Unit
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 27b93c0 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java c49dd08 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7262964

>   oozie/src/main/java/org/apache/oozie/client/LocalOozieClientCoordProxy.java 093d6ff

>   oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java 6ae92de 
>   prism/src/main/java/org/apache/falcon/resource/admin/AdminResource.java ace21cb 
>   unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 9f2b714 
>   unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java 42adc9a

>   unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 42cb779 
>   unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 2c8642d 
>   webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 8dbbd7d

>   webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java 37442c3 
> 
> Diff: https://reviews.apache.org/r/40474/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message